Skip to content

Commit 26c0b15

Browse files
authored
Make properties public in Grid View Page
Properties such as **`pageNo`**, **`sortField`**, and **`sortOrder`** are available in **`MultipleLinkPage`**, but they are not exposed in the new **`AbstractGridViewPage`** implementation. There’s no clear justification for limiting access to these attributes. As a developer, I may need direct access to these properties, for example, to persist user preferences, implement custom pagination or sorting behavior, or synchronize state between the frontend and backend. Therefore, it would be beneficial to make these properties accessible (e.g., through protected or public getters), ensuring greater flexibility and consistency with the previous implementation.
1 parent f24343f commit 26c0b15

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

wcfsetup/install/files/lib/page/AbstractGridViewPage.class.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ abstract class AbstractGridViewPage extends AbstractPage
2424
* @var TGridView
2525
*/
2626
protected AbstractGridView $gridView;
27-
protected int $pageNo = 1;
28-
protected string $sortField = '';
29-
protected string $sortOrder = '';
27+
public int $pageNo = 1;
28+
public string $sortField = '';
29+
public string $sortOrder = '';
3030

3131
/**
3232
* @var mixed[]

0 commit comments

Comments
 (0)