Serialize the EXIF data instead of encoding it as JSON

The parsed data may contain arbitrary binary blobs that cannot be encoded in JSON.

See https://www.woltlab.com/community/thread/314636/

Author: dtdesign

wcfsetup/install/files/acp/database/update_com.woltlab.wcf_6.2_step1.php

@@ -9,6 +9,7 @@
  */
 
 use wcf\system\database\table\column\IntDatabaseTableColumn;
+use wcf\system\database\table\column\MediumblobDatabaseTableColumn;
 use wcf\system\database\table\column\MediumtextDatabaseTableColumn;
 use wcf\system\database\table\column\VarcharDatabaseTableColumn;
 use wcf\system\database\table\column\NotNullVarchar255DatabaseTableColumn;
@@ -69,11 +70,11 @@
     PartialDatabaseTable::create('wcf1_file')
         ->columns([
             IntDatabaseTableColumn::create('uploadTime'),
-            MediumtextDatabaseTableColumn::create('exifData'),
+            MediumblobDatabaseTableColumn::create('exifData'),
         ]),
     PartialDatabaseTable::create('wcf1_file_temporary')
         ->columns([
-            MediumtextDatabaseTableColumn::create('exifData'),
+            MediumblobDatabaseTableColumn::create('exifData'),
         ]),
     PartialDatabaseTable::create('wcf1_menu_item')
         ->columns([

wcfsetup/install/files/acp/update_com.woltlab.wcf_6.1.0_beta_2_migrateStaticFiles.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace wcf\acp;
+
+use wcf\system\package\SplitNodeException;
+use wcf\system\WCF;
+use wcf\util\JSON;
+
+$sql = "UPDATE  wcf1_file_temporary
+        SET     exifData = ?
+        WHERE   identifier = ?";
+$updateStatement = WCF::getDB()->prepare($sql);
+
+WCF::getDB()->beginTransaction();
+
+$sql = "SELECT      identifier, exifData
+        FROM        wcf1_file_temporary
+        WHERE       exifData LIKE ?
+        ORDER BY    identifier
+        FOR UPDATE";
+$statement = WCF::getDB()->prepare($sql, 50);
+$statement->execute(['{"%']);
+
+$replacedData = false;
+while ($row = $statement->fetchArray()) {
+    // This will fail loud but this is only a beta release thus we rather
+    // catch errors than discarding them silently.
+    $data = JSON::decode($row['exifData']);
+
+    $updateStatement->execute([
+        \serialize($data),
+        $row['identifier'],
+    ]);
+
+    $replacedData = true;
+}
+
+WCF::getDB()->commitTransaction();
+
+if ($replacedData) {
+    throw new SplitNodeException();
+}

wcfsetup/install/files/acp/update_com.woltlab.wcf_6.2.0_beta_2_fileTemporary_exifData.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace wcf\acp;
+
+use wcf\system\package\SplitNodeException;
+use wcf\system\WCF;
+use wcf\util\JSON;
+
+$sql = "UPDATE  wcf1_file
+        SET     exifData = ?
+        WHERE   fileID = ?";
+$updateStatement = WCF::getDB()->prepare($sql);
+
+WCF::getDB()->beginTransaction();
+
+$sql = "SELECT      fileID, exifData
+        FROM        wcf1_file
+        WHERE       exifData LIKE ?
+        ORDER BY    fileID
+        FOR UPDATE";
+$statement = WCF::getDB()->prepare($sql, 50);
+$statement->execute(['{"%']);
+
+$replacedData = false;
+while ($row = $statement->fetchArray()) {
+    // This will fail loud but this is only a beta release thus we rather
+    // catch errors than discarding them silently.
+    $data = JSON::decode($row['exifData']);
+
+    $updateStatement->execute([
+        \serialize($data),
+        $row['fileID'],
+    ]);
+
+    $replacedData = true;
+}
+
+WCF::getDB()->commitTransaction();
+
+if ($replacedData) {
+    throw new SplitNodeException();
+}

wcfsetup/install/files/acp/update_com.woltlab.wcf_6.2.0_beta_2_file_exifData.php

@@ -76,7 +76,7 @@ public static function createFromTemporary(FileTemporary $fileTemporary): File
 
         $exifData = $fileTemporary->exifData;
         if ($exifData !== null) {
-            $exifData = JSON::decode($exifData);
+            $exifData = \unserialize($exifData);
         }
 
         $fileSize = $fileTemporary->fileSize;
@@ -115,7 +115,7 @@ public static function createFromTemporary(FileTemporary $fileTemporary): File
             'width' => $width,
             'height' => $height,
             'uploadTime' => \TIME_NOW,
-            'exifData' => $exifData !== null ? JSON::encode($exifData) : null,
+            'exifData' => $exifData !== null ? \serialize($exifData) : null,
         ]]);
         $file = $fileAction->executeAction()['returnValues'];
         \assert($file instanceof File);
@@ -220,7 +220,7 @@ public static function createFromExistingFile(
             'width' => $width,
             'height' => $height,
             'uploadTime' => $uploadTime,
-            'exifData' => $exifData !== null ? JSON::encode($exifData) : null,
+            'exifData' => $exifData !== null ? \serialize($exifData) : null,
         ]]);
         $file = $fileAction->executeAction()['returnValues'];
         \assert($file instanceof File);

wcfsetup/install/files/lib/data/file/FileEditor.class.php

@@ -86,7 +86,7 @@ private function createTemporaryFile(PostUploadParameters $parameters, int $numb
 
         $exifData = $this->parseExifData($exifBytes);
         if ($exifData !== null) {
-            $exifData = JSON::encode($exifData);
+            $exifData = \serialize($exifData);
         }
 
         $action = new FileTemporaryAction([], 'create', [

wcfsetup/install/files/lib/system/endpoint/controller/core/files/PrepareUpload.class.php

@@ -608,7 +608,7 @@ CREATE TABLE wcf1_file (
 	height INT,
 	fileHashWebp CHAR(64),
 	uploadTime INT,
-	exifData MEDIUMTEXT
+	exifData MEDIUMBLOB
 );
 
 DROP TABLE IF EXISTS wcf1_file_temporary;
@@ -621,7 +621,7 @@ CREATE TABLE wcf1_file_temporary (
 	objectTypeID INT,
 	context TEXT,
 	chunks VARBINARY(255) NOT NULL,
-	exifData MEDIUMTEXT
+	exifData MEDIUMBLOB
 );
 
 DROP TABLE IF EXISTS wcf1_file_thumbnail;