Apply suggestions from code review

Co-authored-by: Alexander Ebert <[email protected]>

Author: BurntimeX

wcfsetup/install/files/lib/system/endpoint/controller/core/labels/groups/ChangeLabelShowOrder.class.php

@@ -43,6 +43,9 @@ public function __invoke(ServerRequestInterface $request, array $variables): Res
         return new JsonResponse([]);
     }
 
+    /**
+     * @param list<ShowOrderItem> $items
+     */
     private function saveShowOrder(array $items): void
     {
         $sql = "UPDATE  wcf1_label

wcfsetup/install/files/lib/system/endpoint/controller/core/labels/groups/ChangeShowOrder.class.php

@@ -39,13 +39,11 @@ public function __invoke(ServerRequestInterface $request, array $variables): Res
         return new JsonResponse([]);
     }
 
+    /**
+     * @param list<ShowOrderItem> $items
+     */
     private function saveShowOrder(array $items): void
     {
-        $sql = "UPDATE  wcf1_label
-                SET     showOrder = ?
-                WHERE   labelID = ?";
-        $statement = WCF::getDB()->prepare($sql);
-
         WCF::getDB()->beginTransaction();
         $sql = "UPDATE  wcf1_label_group
                 SET     showOrder = ?

wcfsetup/install/files/lib/system/showOrder/ShowOrderHandler.class.php

@@ -17,7 +17,7 @@
 final class ShowOrderHandler
 {
     /**
-     * @var ShowOrderItem[]
+     * @var list<ShowOrderItem>
      */
     private readonly array $items;