Minor code fixes

Author: dtdesign

com.woltlab.wcf/templates/shared_categorizedSingleSelectionFormField.tpl

@@ -14,7 +14,7 @@
 
 <div class="itemListFilter" id="{$field->getPrefixedId()}_list">
 	<div class="inputAddon">
-		<input type="text" class="long" placeholder="{lang}wcf.global.filter.placeholder{/lang}" />
+		<input type="text" class="long" placeholder="{lang}wcf.global.filter.placeholder{/lang}">
 		<button type="button" class="button clearButton inputSuffix disabled jsTooltip" title="{lang}wcf.global.filter.button.clear{/lang}">{icon name="xmark" solid=true}</button>
 	</div>
 	<ul class="scrollableCheckboxList">
@@ -32,9 +32,9 @@
 						*}> <span>{unsafe:$__fieldNestedOption[label]}</span>
 					</label>
 				{else}
-					<button type="button" class="pointer">{icon name="chevron-down"} {unsafe:$__fieldNestedOption[label]}</button>
+					<button type="button">{icon name="chevron-down"} {unsafe:$__fieldNestedOption[label]}</button>
 				{/if}
 			</li>
 		{/foreach}
 	</ul>
-</div>
+</div>

ts/WoltLabSuite/Core/Component/ItemList/Categorized.ts

@@ -11,25 +11,25 @@ import { innerError, show, hide, isHidden } from "WoltLabSuite/Core/Dom/Util";
 import { getPhrase } from "WoltLabSuite/Core/Language";
 import { escapeRegExp } from "WoltLabSuite/Core/StringUtil";
 
-interface Item {
+type Item = {
   element: HTMLLIElement;
   span: HTMLSpanElement;
   text: string;
-}
+};
 
-interface Category {
+type Category = {
   items: Item[];
   element: HTMLLIElement;
-}
+};
 
 export class CategorizedItemList {
-  #container: HTMLElement;
-  #elementList: HTMLUListElement;
-  #input: HTMLInputElement;
+  readonly #container: HTMLElement;
+  readonly #elementList: HTMLUListElement;
+  readonly #input: HTMLInputElement;
   #value: string = "";
-  #clearButton: HTMLButtonElement;
+  readonly #clearButton: HTMLButtonElement;
   #categories: Category[] = [];
-  #fragment: DocumentFragment;
+  readonly #fragment: DocumentFragment;
 
   constructor(elementId: string) {
     this.#fragment = document.createDocumentFragment();
@@ -72,8 +72,8 @@ export class CategorizedItemList {
 
         category.items.push({
           element: li,
-          span: li.querySelector<HTMLSpanElement>("span")!,
-          text: li.innerText.trim(),
+          span: li.querySelector("span")!,
+          text: li.textContent!.trim(),
         });
       } else {
         const items: Item[] = [];
@@ -96,7 +96,7 @@ export class CategorizedItemList {
     const isOpen = !this.#categoryIsOpen(li);
     li.dataset.open = isOpen ? "true" : "false";
 
-    li.querySelector<FaIcon>("fa-icon")!.setIcon(isOpen ? "chevron-down" : "chevron-right");
+    li.querySelector("fa-icon")!.setIcon(isOpen ? "chevron-down" : "chevron-right");
 
     this.#showItems({
       items: items,

wcfsetup/install/files/js/WoltLabSuite/Core/Component/ItemList/Categorized.js

@@ -114,18 +114,18 @@ private function getOptions(AbstractConditionProvider $provider): array
 
             if (!isset($grouped[$category])) {
                 $grouped[$category] = [
-                    "items" => [],
-                    "label" => WCF::getLanguage()->get('wcf.condition.category.' . $category),
+                    'items' => [],
+                    'label' => WCF::getLanguage()->get('wcf.condition.category.' . $category),
                 ];
             }
 
-            $grouped[$category]["items"][$key] = WCF::getLanguage()->get($label);
+            $grouped[$category]['items'][$key] = WCF::getLanguage()->get($label);
         }
 
         $collator = new \Collator(WCF::getLanguage()->getLocale());
 
         foreach ($grouped as &$category) {
-            \uasort($category["items"], static function ($labelA, $labelB) use ($collator) {
+            \uasort($category['items'], static function ($labelA, $labelB) use ($collator) {
                 return $collator->compare($labelA, $labelB);
             });
         }
@@ -141,11 +141,11 @@ private function getOptions(AbstractConditionProvider $provider): array
             $options[] = [
                 'depth' => 0,
                 'isSelectable' => false,
-                'label' => $category["label"],
+                'label' => $category['label'],
                 'value' => $categoryKey,
             ];
 
-            foreach ($category["items"] as $key => $label) {
+            foreach ($category['items'] as $key => $label) {
                 $options[] = [
                     'depth' => 1,
                     'isSelectable' => true,