Add IMigrateConditionType interface and implement migration methods in user group condition types

Author: Cyperghost

wcfsetup/install/files/lib/system/condition/provider/UserConditionProvider.class.php

@@ -6,6 +6,7 @@
 use wcf\data\user\UserList;
 use wcf\event\condition\provider\UserConditionProviderCollecting;
 use wcf\system\condition\type\IDatabaseObjectListConditionType;
+use wcf\system\condition\type\IMigrateConditionType;
 use wcf\system\condition\type\IObjectConditionType;
 use wcf\system\condition\type\user\AbstractUserBooleanConditionType;
 use wcf\system\condition\type\user\AbstractUserIntegerConditionType;
@@ -62,4 +63,35 @@ public function __construct()
             new UserConditionProviderCollecting($this)
         );
     }
+
+    /**
+     * @param array<string, mixed> $conditionData
+     *
+     * @return array{identifier: string, value: mixed}[]
+     */
+    public function migrateConditionData(array $conditionData): array
+    {
+        if ($conditionData === []) {
+            return [];
+        }
+
+        $result = [];
+
+        foreach ($this->conditionTypes as $conditionType) {
+            if (!($conditionType instanceof IMigrateConditionType)) {
+                continue;
+            }
+
+            \array_push(
+                $result,
+                ...$conditionType->migrateConditionData($conditionData)
+            );
+
+            if ($conditionData === []) {
+                break;
+            }
+        }
+
+        return $result;
+    }
 }

wcfsetup/install/files/lib/system/condition/type/IMigrateConditionType.class.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace wcf\system\condition\type;
+
+/**
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.2
+ */
+interface IMigrateConditionType
+{
+    /**
+     * Converts the old condition structure to the new one. All migrated values must be removed from the `$conditionData` array.
+     *
+     * @param array<string, mixed> $conditionData
+     *
+     * @return array{identifier: string, value: mixed}[]
+     */
+    public function migrateConditionData(array &$conditionData): array;
+}

wcfsetup/install/files/lib/system/condition/type/user/UserInGroupConditionType.class.php

@@ -8,6 +8,7 @@
 use wcf\data\user\UserList;
 use wcf\system\condition\type\AbstractConditionType;
 use wcf\system\condition\type\IDatabaseObjectListConditionType;
+use wcf\system\condition\type\IMigrateConditionType;
 use wcf\system\condition\type\IObjectConditionType;
 use wcf\system\form\builder\field\SelectFormField;
 
@@ -21,7 +22,7 @@
  * @implements IObjectConditionType<User, string>
  * @extends AbstractConditionType<string>
  */
-final class UserInGroupConditionType extends AbstractConditionType implements IDatabaseObjectListConditionType, IObjectConditionType
+final class UserInGroupConditionType extends AbstractConditionType implements IDatabaseObjectListConditionType, IObjectConditionType, IMigrateConditionType
 {
     #[\Override]
     public function getFormField(string $id): SelectFormField
@@ -69,4 +70,24 @@ public function matches(object $object): bool
     {
         return \in_array((int)$this->filter, $object->getGroupIDs(), true);
     }
+
+    #[\Override]
+    public function migrateConditionData(array &$conditionData): array
+    {
+        if (!isset($conditionData['groupIDs'])) {
+            return [];
+        }
+
+        $result = [];
+        foreach ($conditionData['groupIDs'] as $groupID) {
+            $result[] = [
+                'identifier' => $this->getIdentifier(),
+                'value' => $groupID,
+            ];
+        }
+
+        unset($conditionData['groupIDs']);
+
+        return $result;
+    }
 }

wcfsetup/install/files/lib/system/condition/type/user/UserNotInGroupConditionType.class.php

@@ -8,6 +8,7 @@
 use wcf\data\user\UserList;
 use wcf\system\condition\type\AbstractConditionType;
 use wcf\system\condition\type\IDatabaseObjectListConditionType;
+use wcf\system\condition\type\IMigrateConditionType;
 use wcf\system\condition\type\IObjectConditionType;
 use wcf\system\form\builder\field\SelectFormField;
 
@@ -21,7 +22,7 @@
  * @implements IObjectConditionType<User, string>
  * @extends AbstractConditionType<string>
  */
-final class UserNotInGroupConditionType extends AbstractConditionType implements IDatabaseObjectListConditionType, IObjectConditionType
+final class UserNotInGroupConditionType extends AbstractConditionType implements IDatabaseObjectListConditionType, IObjectConditionType, IMigrateConditionType
 {
     #[\Override]
     public function getFormField(string $id): SelectFormField
@@ -69,4 +70,24 @@ public function matches(object $object): bool
     {
         return !\in_array((int)$this->filter, $object->getGroupIDs(), true);
     }
+
+    #[\Override]
+    public function migrateConditionData(array &$conditionData): array
+    {
+        if (!isset($conditionData['notGroupIDs'])) {
+            return [];
+        }
+
+        $result = [];
+        foreach ($conditionData['notGroupIDs'] as $groupID) {
+            $result[] = [
+                'identifier' => $this->getIdentifier(),
+                'value' => $groupID,
+            ];
+        }
+
+        unset($conditionData['notGroupIDs']);
+
+        return $result;
+    }
 }