Add required validation for condition form fields

Author: Cyperghost

com.woltlab.wcf/templates/shared_conditionFormContainer.tpl

@@ -21,6 +21,10 @@
 	<button type="button" class="button" id="{$container->getPrefixedId()}AddCondition">
 		{lang}wcf.condition.add{/lang}
 	</button>
+
+	{if $container->isRequired() && $container->isEmpty()}
+		<small class="innerError">{lang}wcf.global.form.error.empty{/lang}</small>
+	{/if}
 </section>
 
 {include file='shared_formContainerDependencies'}

wcfsetup/install/files/lib/acp/form/TrophyAddForm.class.php

@@ -160,11 +160,11 @@ public function createForm()
                         ->fieldId('type')
                         ->values([Trophy::TYPE_BADGE])
                 ),
-            // TODO make it required
             ConditionFormContainer::create()
                 ->label('wcf.acp.trophy.conditions')
                 ->description('wcf.acp.trophy.conditions.description')
                 ->conditionProvider(new UserConditionProvider())
+                ->required()
                 ->addDependency(
                     NonEmptyFormFieldDependency::create('awardAutomaticallyDependency')
                         ->fieldId('awardAutomatically')

wcfsetup/install/files/lib/system/form/builder/container/condition/ConditionFormContainer.class.php

@@ -31,13 +31,24 @@ final class ConditionFormContainer extends FormContainer
      * @phpstan-ignore missingType.generics
      */
     protected AbstractConditionProvider $conditionProvider;
+    private bool $isRequired = false;
 
     public function __construct()
     {
         parent::__construct();
         $this->label("wcf.form.field.condition");
     }
 
+    public function hasValidationErrors(): bool
+    {
+        if ($this->isRequired && $this->isEmpty()) {
+            return true;
+        }
+
+        return parent::hasValidationErrors();
+    }
+
+
     #[\Override]
     protected static function getDefaultId(): string
     {
@@ -165,4 +176,21 @@ public function getConditionProviderClass(): string
 
         return $this->conditionProvider::class;
     }
+
+    public function required(bool $isRequired = true): self
+    {
+        $this->isRequired = $isRequired;
+
+        return $this;
+    }
+
+    public function isRequired(): bool
+    {
+        return $this->isRequired;
+    }
+
+    public function isEmpty(): bool
+    {
+        return !$this->hasChildren();
+    }
 }