Migrate the function to disable/enable user group assignments to a command

Author: Cyperghost

wcfsetup/install/files/lib/command/user/group/assignment/DisableUserGroupAssignment.class.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace wcf\command\user\group\assignment;
+
+use wcf\data\user\group\assignment\UserGroupAssignment;
+use wcf\data\user\group\assignment\UserGroupAssignmentEditor;
+use wcf\event\user\group\assignment\UserGroupAssignmentDisabled;
+use wcf\system\event\EventHandler;
+
+/**
+ * Disables a user group assignment.
+ *
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.3
+ */
+final class DisableUserGroupAssignment
+{
+    public function __construct(private readonly UserGroupAssignment $assignment) {}
+
+    public function __invoke(): void
+    {
+        if ($this->assignment->isDisabled) {
+            return;
+        }
+
+        (new UserGroupAssignmentEditor($this->assignment))->update([
+            'isDisabled' => 1,
+        ]);
+
+        $event = new UserGroupAssignmentDisabled($this->assignment);
+        EventHandler::getInstance()->fire($event);
+    }
+}

wcfsetup/install/files/lib/command/user/group/assignment/EnableUserGroupAssignment.class.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace wcf\command\user\group\assignment;
+
+use wcf\data\user\group\assignment\UserGroupAssignment;
+use wcf\data\user\group\assignment\UserGroupAssignmentEditor;
+use wcf\event\user\group\assignment\UserGroupAssignmentEnabled;
+use wcf\system\event\EventHandler;
+
+/**
+ * Enables a user group assignment.
+ *
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.3
+ */
+final class EnableUserGroupAssignment
+{
+    public function __construct(private readonly UserGroupAssignment $assignment) {}
+
+    public function __invoke(): void
+    {
+        if (!$this->assignment->isDisabled) {
+            return;
+        }
+
+        (new UserGroupAssignmentEditor($this->assignment))->update([
+            'isDisabled' => 0,
+        ]);
+
+        $event = new UserGroupAssignmentEnabled($this->assignment);
+        EventHandler::getInstance()->fire($event);
+    }
+}

wcfsetup/install/files/lib/data/user/group/assignment/UserGroupAssignmentAction.class.php

@@ -2,9 +2,10 @@
 
 namespace wcf\data\user\group\assignment;
 
+use wcf\command\user\group\assignment\DisableUserGroupAssignment;
+use wcf\command\user\group\assignment\EnableUserGroupAssignment;
 use wcf\data\AbstractDatabaseObjectAction;
 use wcf\data\IToggleAction;
-use wcf\data\TDatabaseObjectToggle;
 use wcf\system\condition\ConditionHandler;
 
 /**
@@ -18,8 +19,6 @@
  */
 class UserGroupAssignmentAction extends AbstractDatabaseObjectAction implements IToggleAction
 {
-    use TDatabaseObjectToggle;
-
     /**
      * @inheritDoc
      */
@@ -47,4 +46,26 @@ public function delete()
 
         return parent::delete();
     }
+
+    /**
+     * @deprecated 6.3
+     */
+    public function validateToggle()
+    {
+        $this->validateUpdate();
+    }
+
+    /**
+     * @deprecated 6.3 use the `EnableUserGroupAssignment` or `DisableUserGroupAssignment` commands instead.
+     */
+    public function toggle()
+    {
+        foreach ($this->objects as $editor) {
+            if ($editor->isDisabled) {
+                (new EnableUserGroupAssignment($editor->getDecoratedObject()))();
+            } else {
+                (new DisableUserGroupAssignment($editor->getDecoratedObject()))();
+            }
+        }
+    }
 }

wcfsetup/install/files/lib/event/user/group/assignment/UserGroupAssignmentDisabled.class.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace wcf\event\user\group\assignment;
+
+use wcf\data\user\group\assignment\UserGroupAssignment;
+use wcf\event\IPsr14Event;
+
+/**
+ * Indicates that a user group assignment has been disabled.
+ *
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.3
+ */
+final class UserGroupAssignmentDisabled implements IPsr14Event
+{
+    public function __construct(public readonly UserGroupAssignment $assignment) {}
+}

wcfsetup/install/files/lib/event/user/group/assignment/UserGroupAssignmentEnabled.class.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace wcf\event\user\group\assignment;
+
+use wcf\data\user\group\assignment\UserGroupAssignment;
+use wcf\event\IPsr14Event;
+
+/**
+ * Indicates that a user group assignment has been enabled.
+ *
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.3
+ */
+final class UserGroupAssignmentEnabled implements IPsr14Event
+{
+    public function __construct(public readonly UserGroupAssignment $assignment) {}
+}

wcfsetup/install/files/lib/system/endpoint/controller/core/users/groups/assignment/DisableAssignment.class.php

@@ -5,12 +5,11 @@
 use Laminas\Diactoros\Response\JsonResponse;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
+use wcf\command\user\group\assignment\DisableUserGroupAssignment;
 use wcf\data\user\group\assignment\UserGroupAssignment;
-use wcf\data\user\group\assignment\UserGroupAssignmentAction;
 use wcf\http\Helper;
 use wcf\system\endpoint\IController;
 use wcf\system\endpoint\PostRequest;
-use wcf\system\exception\PermissionDeniedException;
 use wcf\system\WCF;
 
 /**
@@ -28,19 +27,15 @@ public function __invoke(ServerRequestInterface $request, array $variables): Res
     {
         $assignment = Helper::fetchObjectFromRequestParameter($variables['id'], UserGroupAssignment::class);
 
-        $this->assertAssignmentCanBeDisabled($assignment);
+        $this->assertAssignmentCanBeDisabled();
 
-        (new UserGroupAssignmentAction([$assignment], 'toggle'))->executeAction();
+        (new DisableUserGroupAssignment($assignment))();
 
         return new JsonResponse([]);
     }
 
-    private function assertAssignmentCanBeDisabled(UserGroupAssignment $assignment): void
+    private function assertAssignmentCanBeDisabled(): void
     {
         WCF::getSession()->checkPermissions(['admin.management.canManageCronjob']);
-
-        if ($assignment->isDisabled) {
-            throw new PermissionDeniedException();
-        }
     }
 }

wcfsetup/install/files/lib/system/endpoint/controller/core/users/groups/assignment/EnableAssignment.class.php

@@ -5,12 +5,11 @@
 use Laminas\Diactoros\Response\JsonResponse;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
+use wcf\command\user\group\assignment\EnableUserGroupAssignment;
 use wcf\data\user\group\assignment\UserGroupAssignment;
-use wcf\data\user\group\assignment\UserGroupAssignmentAction;
 use wcf\http\Helper;
 use wcf\system\endpoint\IController;
 use wcf\system\endpoint\PostRequest;
-use wcf\system\exception\PermissionDeniedException;
 use wcf\system\WCF;
 
 /**
@@ -28,19 +27,15 @@ public function __invoke(ServerRequestInterface $request, array $variables): Res
     {
         $assignment = Helper::fetchObjectFromRequestParameter($variables['id'], UserGroupAssignment::class);
 
-        $this->assertAssignmentCanBeEnabled($assignment);
+        $this->assertAssignmentCanBeEnabled();
 
-        (new UserGroupAssignmentAction([$assignment], 'toggle'))->executeAction();
+        (new EnableUserGroupAssignment($assignment))();
 
         return new JsonResponse([]);
     }
 
-    private function assertAssignmentCanBeEnabled(UserGroupAssignment $assignment): void
+    private function assertAssignmentCanBeEnabled(): void
     {
         WCF::getSession()->checkPermissions(['admin.management.canManageCronjob']);
-
-        if (!$assignment->isDisabled) {
-            throw new PermissionDeniedException();
-        }
     }
 }