Improve the type safety

Author: dtdesign

phpstan-ambient.neon

@@ -230,3 +230,5 @@ parameters:
         - SERVICE_WORKER_PRIVATE_KEY
         - SERVICE_WORKER_PUBLIC_KEY
         - RECAPTCHA_PRIVATEKEY_V3
+        - IMAGE_CONVERT_FORMAT
+        - IMAGE_STRIP_EXIF

wcfsetup/install/files/lib/data/file/FileEditor.class.php

@@ -121,6 +121,9 @@ public static function createFromTemporary(FileTemporary $fileTemporary): File
         return $event->getFile();
     }
 
+    /**
+     * @param null|array<string, array<string, mixed>> $exifData
+     */
     public static function createFromExistingFile(
         string $pathname,
         string $originalFilename,

wcfsetup/install/files/lib/system/endpoint/controller/core/files/PrepareUpload.class.php

@@ -103,7 +103,10 @@ private function createTemporaryFile(PostUploadParameters $parameters, int $numb
         return $action->executeAction()['returnValues'];
     }
 
-    private function parseExifData(?string $exifData): array|null
+    /**
+     * @return array<string, array<string, mixed>>|null
+     */
+    private function parseExifData(?string $exifData): ?array
     {
         if ($exifData === null) {
             return null;

wcfsetup/install/files/lib/system/file/processor/AttachmentFileProcessor.class.php

@@ -170,7 +170,7 @@ public function getResizeConfiguration(): ResizeConfiguration
             \ATTACHMENT_IMAGE_AUTOSCALE_MAX_WIDTH,
             \ATTACHMENT_IMAGE_AUTOSCALE_MAX_HEIGHT,
             ResizeFileType::fromString(\ATTACHMENT_IMAGE_AUTOSCALE_FILE_TYPE),
-            \ATTACHMENT_IMAGE_AUTOSCALE_QUALITY
+            80
         );
     }