Update to PHPStan v2.1.32

Author: dtdesign

composer.lock

@@ -6,12 +6,6 @@ parameters:
 			count: 1
 			path: wcfsetup/install/files/lib/acp/form/AbstractCategoryEditForm.class.php
 
-		-
-			message: '#^Strict comparison using \=\=\= between array and false will always evaluate to false\.$#'
-			identifier: identical.alwaysFalse
-			count: 1
-			path: wcfsetup/install/files/lib/acp/form/LanguageAddForm.class.php
-
 		-
 			message: '#^Property wcf\\acp\\form\\LanguageImportForm\:\:\$language \(wcf\\data\\language\\Language\) does not accept wcf\\data\\language\\LanguageEditor\.$#'
 			identifier: assign.propertyType
@@ -66,12 +60,6 @@ parameters:
 			count: 2
 			path: wcfsetup/install/files/lib/data/comment/CommentAction.class.php
 
-		-
-			message: '#^While loop condition is always true\.$#'
-			identifier: while.alwaysTrue
-			count: 1
-			path: wcfsetup/install/files/lib/data/user/notification/event/UserNotificationEventAction.class.php
-
 		-
 			message: '#^Instanceof between wcf\\data\\search\\ISearchResultObject and wcf\\data\\search\\ISearchResultObject will always evaluate to true\.$#'
 			identifier: instanceof.alwaysTrue
@@ -354,12 +342,6 @@ parameters:
 			count: 1
 			path: wcfsetup/install/files/lib/system/condition/AbstractMultiSelectCondition.class.php
 
-		-
-			message: '#^Parameter \#2 \$array of function implode expects array\|null, string given\.$#'
-			identifier: argument.type
-			count: 1
-			path: wcfsetup/install/files/lib/system/condition/AbstractObjectTextPropertyCondition.class.php
-
 		-
 			message: '#^Strict comparison using \=\=\= between array\<mixed\> and null will always evaluate to false\.$#'
 			identifier: identical.alwaysFalse
@@ -462,12 +444,6 @@ parameters:
 			count: 1
 			path: wcfsetup/install/files/lib/system/condition/user/UserLastActivityTimeIntervalDaysCondition.class.php
 
-		-
-			message: '#^Strict comparison using \=\=\= between string and null will always evaluate to false\.$#'
-			identifier: identical.alwaysFalse
-			count: 1
-			path: wcfsetup/install/files/lib/system/database/statement/PreparedStatement.class.php
-
 		-
 			message: '#^Instanceof between wcf\\system\\database\\table\\column\\IDatabaseTableColumn and wcf\\system\\database\\table\\column\\IDatabaseTableColumn will always evaluate to true\.$#'
 			identifier: instanceof.alwaysTrue
@@ -528,12 +504,6 @@ parameters:
 			count: 1
 			path: wcfsetup/install/files/lib/system/form/builder/CustomFormNode.class.php
 
-		-
-			message: '#^Empty array passed to foreach\.$#'
-			identifier: foreach.emptyArray
-			count: 2
-			path: wcfsetup/install/files/lib/system/form/builder/CustomFormNode.class.php
-
 		-
 			message: '#^Result of && is always false\.$#'
 			identifier: booleanAnd.alwaysFalse
@@ -582,12 +552,6 @@ parameters:
 			count: 1
 			path: wcfsetup/install/files/lib/system/form/builder/GridViewFormNode.class.php
 
-		-
-			message: '#^Empty array passed to foreach\.$#'
-			identifier: foreach.emptyArray
-			count: 2
-			path: wcfsetup/install/files/lib/system/form/builder/GridViewFormNode.class.php
-
 		-
 			message: '#^Result of && is always false\.$#'
 			identifier: booleanAnd.alwaysFalse
@@ -612,12 +576,6 @@ parameters:
 			count: 1
 			path: wcfsetup/install/files/lib/system/form/builder/LanguageItemFormNode.class.php
 
-		-
-			message: '#^Empty array passed to foreach\.$#'
-			identifier: foreach.emptyArray
-			count: 2
-			path: wcfsetup/install/files/lib/system/form/builder/LanguageItemFormNode.class.php
-
 		-
 			message: '#^Result of && is always false\.$#'
 			identifier: booleanAnd.alwaysFalse
@@ -642,12 +600,6 @@ parameters:
 			count: 1
 			path: wcfsetup/install/files/lib/system/form/builder/TemplateFormNode.class.php
 
-		-
-			message: '#^Empty array passed to foreach\.$#'
-			identifier: foreach.emptyArray
-			count: 2
-			path: wcfsetup/install/files/lib/system/form/builder/TemplateFormNode.class.php
-
 		-
 			message: '#^Result of && is always false\.$#'
 			identifier: booleanAnd.alwaysFalse
@@ -672,12 +624,6 @@ parameters:
 			count: 3
 			path: wcfsetup/install/files/lib/system/form/builder/button/FormButton.class.php
 
-		-
-			message: '#^Empty array passed to foreach\.$#'
-			identifier: foreach.emptyArray
-			count: 2
-			path: wcfsetup/install/files/lib/system/form/builder/button/FormButton.class.php
-
 		-
 			message: '#^Result of && is always false\.$#'
 			identifier: booleanAnd.alwaysFalse
@@ -738,12 +684,6 @@ parameters:
 			count: 3
 			path: wcfsetup/install/files/lib/system/form/builder/field/AbstractFormField.class.php
 
-		-
-			message: '#^Empty array passed to foreach\.$#'
-			identifier: foreach.emptyArray
-			count: 2
-			path: wcfsetup/install/files/lib/system/form/builder/field/AbstractFormField.class.php
-
 		-
 			message: '#^Result of && is always false\.$#'
 			identifier: booleanAnd.alwaysFalse
@@ -906,12 +846,6 @@ parameters:
 			count: 1
 			path: wcfsetup/install/files/lib/system/form/builder/wysiwyg/WysiwygSmileyFormNode.class.php
 
-		-
-			message: '#^Empty array passed to foreach\.$#'
-			identifier: foreach.emptyArray
-			count: 2
-			path: wcfsetup/install/files/lib/system/form/builder/wysiwyg/WysiwygSmileyFormNode.class.php
-
 		-
 			message: '#^Result of && is always false\.$#'
 			identifier: booleanAnd.alwaysFalse
@@ -1067,9 +1001,3 @@ parameters:
 			identifier: argument.type
 			count: 2
 			path: wcfsetup/install/files/lib/util/DirectoryUtil.class.php
-
-		-
-			message: '#^Property wcf\\util\\DirectoryUtil\:\:\$fileObjects \(array\<DirectoryIterator\>\) does not accept array\<SplFileInfo\>\.$#'
-			identifier: assign.propertyType
-			count: 1
-			path: wcfsetup/install/files/lib/util/DirectoryUtil.class.php

phpstan-baseline.neon

@@ -4,6 +4,9 @@ includes:
 
 parameters:
     level: 6
+    phpVersion:
+        min: 80102
+        max: 80499
     paths:
         - wcfsetup/install/files
     excludePaths:

phpstan.neon

@@ -118,14 +118,17 @@ private function getIssuesPreventingUpgrade(): array
 
     /**
      * @return ?array{title: string, description: string}
+     * @phpstan-ignore return.unusedType
      */
     private function checkMinimumPhpVersion(): ?array
     {
         // Minimum: PHP 8.1.2
+        // @phpstan-ignore greaterOrEqual.alwaysTrue
         if (\PHP_VERSION_ID >= 80102) {
             return null;
         }
 
+        // @phpstan-ignore deadCode.unreachable
         if (WCF::getLanguage()->getFixedLanguageCode() === 'de') {
             return [
                 'title' => 'Unzureichende PHP-Version',

wcfsetup/install/files/lib/acp/form/PackageEnableUpgradeOverrideForm.class.php

@@ -33,6 +33,7 @@ public function execute(): JsonResponse
             // background job's memory usage without a memory-heavy job skewing the numbers for
             // the following jobs.
             if (\PHP_VERSION_ID >= 80200) {
+                // @phpstan-ignore function.notFound
                 \memory_reset_peak_usage();
             }
 

wcfsetup/install/files/lib/action/BackgroundQueuePerformAction.class.php

@@ -25,12 +25,12 @@
  *
  * @property-read   int $articleContentID   unique id of the article content
  * @property-read   int $articleID      id of the article the article content belongs to
- * @property-read   int $languageID     id of the article content's language
+ * @property-read   ?int $languageID     id of the article content's language
  * @property-read   string $title          title of the article in the associated language
- * @property-read   string $content        actual content of the article in the associated language
- * @property-read   string $teaser         teaser of the article in the associated language or empty if no teaser exists
- * @property-read   int|null $imageID        id of the (image) media object used as article image for the associated language or `null` if no image is used
- * @property-read   int|null $teaserImageID          id of the (image) media object used as article teaser image for the associated language or `null` if no image is used
+ * @property-read   ?string $content        actual content of the article in the associated language
+ * @property-read   ?string $teaser         teaser of the article in the associated language or empty if no teaser exists
+ * @property-read   ?int $imageID        id of the (image) media object used as article image for the associated language or `null` if no image is used
+ * @property-read   ?int $teaserImageID          id of the (image) media object used as article teaser image for the associated language or `null` if no image is used
  * @property-read   int $hasEmbeddedObjects is `1` if there are embedded objects in the article content, otherwise `0`
  * @property-read       string $metaTitle              title of the article used in the title tag
  * @property-read       string $metaDescription        meta description of the article

wcfsetup/install/files/lib/data/article/content/ArticleContent.class.php

@@ -114,6 +114,7 @@ public function getParentCategories()
     public function getParentCategory()
     {
         if ($this->parentCategoryID && $this->parentCategory === null) {
+            // @phpstan-ignore assign.propertyType
             $this->parentCategory = new static($this->getDecoratedObject()->getParentCategory());
         }
 
@@ -139,6 +140,7 @@ public static function getCategory($categoryID)
     {
         $category = CategoryHandler::getInstance()->getCategory($categoryID);
         if ($category) {
+            // @phpstan-ignore return.type
             return new static($category);
         }
 

wcfsetup/install/files/lib/data/category/AbstractDecoratedCategory.class.php

@@ -22,7 +22,7 @@
  * @property-read   int $objectTypeID               id of the `com.woltlab.wcf.comment.commentableContent` object type
  * @property-read   int $objectID                   id of the commented object of the object type represented by `$objectTypeID`
  * @property-read   int $time                       timestamp at which the comment has been written
- * @property-read   int|null $userID                id of the user who wrote the comment or `null` if the user does not exist anymore or if the comment has been written by a guest
+ * @property-read   ?int $userID                id of the user who wrote the comment or `null` if the user does not exist anymore or if the comment has been written by a guest
  * @property-read   string $username                name of the user or guest who wrote the comment
  * @property-read   string $message                 comment message
  * @property-read   int $responses                  number of responses on the comment
@@ -44,7 +44,7 @@ class Comment extends DatabaseObject implements IMessage
      */
     public function getResponseIDs()
     {
-        if ($this->responseIDs === null || $this->responseIDs == '') {
+        if ($this->responseIDs === '') {
             return [];
         }
 
@@ -63,7 +63,7 @@ public function getResponseIDs()
      */
     public function getUnfilteredResponseIDs()
     {
-        if ($this->unfilteredResponseIDs === null || $this->unfilteredResponseIDs == '') {
+        if ($this->unfilteredResponseIDs === '') {
             return [];
         }
 

wcfsetup/install/files/lib/data/comment/Comment.class.php

@@ -17,7 +17,7 @@
  * @since   5.3
  *
  * @property-read   int $itemID     unique id of the missing language item log entry
- * @property-read   int $languageID id of the language the missing language item was requested for
+ * @property-read   ?int $languageID id of the language the missing language item was requested for
  * @property-read   string $languageItem   name of the missing language item
  * @property-read   int $lastTime   timestamp of the last time the missing language item was requested
  * @property-read   string $stackTrace stack trace of how the missing language item was requested for the last time

wcfsetup/install/files/lib/data/devtools/missing/language/item/DevtoolsMissingLanguageItem.class.php

@@ -19,12 +19,12 @@
  * @property-read   int $likeObjectID       unique id of the liked object
  * @property-read   int $objectTypeID       id of the `com.woltlab.wcf.like.likeableObject` object type
  * @property-read   int $objectID       id of the liked object
- * @property-read   int|null $objectUserID       id of the user who created the liked object or null if user has been deleted or object was created by guest
+ * @property-read   ?int $objectUserID       id of the user who created the liked object or null if user has been deleted or object was created by guest
  * @property-read   int $likes          number of likes of the liked object
  * @property-read   int $dislikes       legacy column, not used anymore
  * @property-read   int $cumulativeLikes    number of likes of the liked object
- * @property-read   string $cachedUsers        serialized array with the ids and names of the three users who liked (+1) the object last
- * @property-read   string $cachedReactions    serialized array with the reactionTypeIDs and the count of the reactions
+ * @property-read   ?string $cachedUsers        serialized array with the ids and names of the three users who liked (+1) the object last
+ * @property-read   ?string $cachedReactions    serialized array with the reactionTypeIDs and the count of the reactions
  * @property-read   int $reactionTypeID
  * @phpstan-type ReactionData array{
  *  reactionCount: int,