Rename IGlobalConditionType to IContextualConditionType

Cyperghost · Cyperghost · commit 97be7f56caf6 · 2025-07-16T13:09:05.000+02:00
diff --git a/wcfsetup/install/files/lib/system/condition/provider/RequestConditionProvider.class.php b/wcfsetup/install/files/lib/system/condition/provider/RequestConditionProvider.class.php
@@ -2,7 +2,7 @@
 
 namespace wcf\system\condition\provider;
 
-use wcf\system\condition\type\IGlobalConditionType;
+use wcf\system\condition\type\IContextualConditionType;
 use wcf\system\condition\type\request\ActivePageRequestConditionType;
 use wcf\system\condition\type\request\DayOfWeekRequestConditionType;
 use wcf\system\condition\type\request\NotDayOfWeekRequestConditionType;
@@ -15,7 +15,7 @@
  * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
  * @since 6.3
  *
- * @phpstan-type RequestConditionType IGlobalConditionType<mixed>
+ * @phpstan-type RequestConditionType IContextualConditionType<mixed>
  * @extends AbstractConditionProvider<RequestConditionType>
  */
 final class RequestConditionProvider extends AbstractConditionProvider
diff --git a/wcfsetup/install/files/lib/system/condition/type/IContextualConditionType.class.php b/wcfsetup/install/files/lib/system/condition/type/IContextualConditionType.class.php
@@ -11,7 +11,7 @@
  * @template TFilter
  * @extends  IConditionType<TFilter>
  */
-interface IGlobalConditionType extends IConditionType
+interface IContextualConditionType extends IConditionType
 {
     /**
      * Returns `true` if the condition matches the global context (e.g., the active user via `WCF::getUser()`).
diff --git a/wcfsetup/install/files/lib/system/condition/type/request/ActivePageRequestConditionType.class.php b/wcfsetup/install/files/lib/system/condition/type/request/ActivePageRequestConditionType.class.php
@@ -4,7 +4,7 @@
 
 use wcf\data\page\PageNodeTree;
 use wcf\system\condition\type\AbstractConditionType;
-use wcf\system\condition\type\IGlobalConditionType;
+use wcf\system\condition\type\IContextualConditionType;
 use wcf\system\condition\type\IMigrateConditionType;
 use wcf\system\form\builder\field\SingleSelectionFormField;
 use wcf\system\request\RequestHandler;
@@ -15,10 +15,10 @@
  * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
  * @since 6.3
  *
- * @implements IGlobalConditionType<string>
+ * @implements IContextualConditionType<string>
  * @extends AbstractConditionType<string>
  */
-final class ActivePageRequestConditionType extends AbstractConditionType implements IGlobalConditionType, IMigrateConditionType
+final class ActivePageRequestConditionType extends AbstractConditionType implements IContextualConditionType, IMigrateConditionType
 {
     #[\Override]
     public function getIdentifier(): string
diff --git a/wcfsetup/install/files/lib/system/condition/type/request/DayOfWeekRequestConditionType.class.php b/wcfsetup/install/files/lib/system/condition/type/request/DayOfWeekRequestConditionType.class.php
@@ -3,7 +3,7 @@
 namespace wcf\system\condition\type\request;
 
 use wcf\system\condition\type\AbstractConditionType;
-use wcf\system\condition\type\IGlobalConditionType;
+use wcf\system\condition\type\IContextualConditionType;
 use wcf\system\condition\type\IMigrateConditionType;
 use wcf\system\form\builder\field\SingleSelectionFormField;
 use wcf\system\WCF;
@@ -15,10 +15,10 @@
  * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
  * @since 6.3
  *
- * @implements IGlobalConditionType<string>
+ * @implements IContextualConditionType<string>
  * @extends AbstractConditionType<string>
  */
-final class DayOfWeekRequestConditionType extends AbstractConditionType implements IGlobalConditionType, IMigrateConditionType
+final class DayOfWeekRequestConditionType extends AbstractConditionType implements IContextualConditionType, IMigrateConditionType
 {
     #[\Override]
     public function getIdentifier(): string
diff --git a/wcfsetup/install/files/lib/system/condition/type/request/NotDayOfWeekRequestConditionType.class.php b/wcfsetup/install/files/lib/system/condition/type/request/NotDayOfWeekRequestConditionType.class.php
@@ -3,7 +3,7 @@
 namespace wcf\system\condition\type\request;
 
 use wcf\system\condition\type\AbstractConditionType;
-use wcf\system\condition\type\IGlobalConditionType;
+use wcf\system\condition\type\IContextualConditionType;
 use wcf\system\condition\type\IMigrateConditionType;
 use wcf\system\form\builder\field\SingleSelectionFormField;
 use wcf\system\WCF;
@@ -15,10 +15,10 @@
  * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
  * @since 6.3
  *
- * @implements IGlobalConditionType<string>
+ * @implements IContextualConditionType<string>
  * @extends AbstractConditionType<string>
  */
-final class NotDayOfWeekRequestConditionType extends AbstractConditionType implements IGlobalConditionType, IMigrateConditionType
+final class NotDayOfWeekRequestConditionType extends AbstractConditionType implements IContextualConditionType, IMigrateConditionType
 {
     #[\Override]
     public function getIdentifier(): string
diff --git a/wcfsetup/install/files/lib/system/condition/type/request/NotOnPageRequestConditionType.class.php b/wcfsetup/install/files/lib/system/condition/type/request/NotOnPageRequestConditionType.class.php
@@ -4,7 +4,7 @@
 
 use wcf\data\page\PageNodeTree;
 use wcf\system\condition\type\AbstractConditionType;
-use wcf\system\condition\type\IGlobalConditionType;
+use wcf\system\condition\type\IContextualConditionType;
 use wcf\system\condition\type\IMigrateConditionType;
 use wcf\system\form\builder\field\SingleSelectionFormField;
 use wcf\system\request\RequestHandler;
@@ -16,10 +16,10 @@
  * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
  * @since 6.3
  *
- * @implements IGlobalConditionType<string>
+ * @implements IContextualConditionType<string>
  * @extends AbstractConditionType<string>
  */
-final class NotOnPageRequestConditionType extends AbstractConditionType implements IGlobalConditionType, IMigrateConditionType
+final class NotOnPageRequestConditionType extends AbstractConditionType implements IContextualConditionType, IMigrateConditionType
 {
     #[\Override]
     public function getIdentifier(): string
diff --git a/wcfsetup/install/files/lib/system/condition/type/request/TimeRequestConditionType.class.php b/wcfsetup/install/files/lib/system/condition/type/request/TimeRequestConditionType.class.php
@@ -3,7 +3,7 @@
 namespace wcf\system\condition\type\request;
 
 use wcf\system\condition\type\AbstractConditionType;
-use wcf\system\condition\type\IGlobalConditionType;
+use wcf\system\condition\type\IContextualConditionType;
 use wcf\system\condition\type\IMigrateConditionType;
 use wcf\system\form\builder\container\condition\RowConditionFormFieldContainer;
 use wcf\system\form\builder\field\SingleSelectionFormField;
@@ -18,10 +18,10 @@
  * @since 6.3
  *
  * @phpstan-type Filter = array{Condition: string, Value: string, Timezone: string}
- * @implements IGlobalConditionType<Filter>
+ * @implements IContextualConditionType<Filter>
  * @extends AbstractConditionType<Filter>
  */
-final class TimeRequestConditionType extends AbstractConditionType implements IGlobalConditionType, IMigrateConditionType
+final class TimeRequestConditionType extends AbstractConditionType implements IContextualConditionType, IMigrateConditionType
 {
     public const USER_TIMEZONE = 'userTimezone';
 
diff --git a/wcfsetup/install/files/lib/system/notice/NoticeHandler.class.php b/wcfsetup/install/files/lib/system/notice/NoticeHandler.class.php
@@ -6,7 +6,7 @@
 use wcf\system\cache\eager\NoticeCache;
 use wcf\system\condition\ConditionHandler;
 use wcf\system\condition\provider\combined\NoticeConditionProvider;
-use wcf\system\condition\type\IGlobalConditionType;
+use wcf\system\condition\type\IContextualConditionType;
 use wcf\system\SingletonFactory;
 use wcf\system\WCF;
 
@@ -59,7 +59,7 @@ public function getVisibleNotices()
 
             $conditions = ConditionHandler::getInstance()->getConditionsWithFilter($provider, $notice->getConditions());
             foreach ($conditions as $condition) {
-                $matches = $condition instanceof IGlobalConditionType
+                $matches = $condition instanceof IContextualConditionType
                     ? $condition->matches()
                     : $condition->matches(WCF::getUser());
 

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`* @template TFilter`
`12`	`12`	`* @extends IConditionType<TFilter>`
`13`	`13`	`*/`
`14`		`-interface IGlobalConditionType extends IConditionType`
	`14`	`+interface IContextualConditionType extends IConditionType`
`15`	`15`	`{`
`16`	`16`	`/**`
`17`	`17`	* Returns `true` if the condition matches the global context (e.g., the active user via `WCF::getUser()`).