Apply suggestions from code review

Author: BurntimeX

com.woltlab.wcf/templates/article.tpl

@@ -121,42 +121,35 @@
 		{/if}
 
 		{hascontent}
-			<ul class="entry__footerButtons buttonGroup buttonList smallButtons" role="menu">
+			<div class="entry__footerButtons">
 				{content}
 					{if $__wcf->session->getPermission('user.profile.canReportContent')}
-						<li role="presentation">
-							<button
-								type="button"
-								role="menuitem"
-								title="{lang}wcf.moderation.report.reportContent{/lang}"
-								class="button jsTooltip"
-								data-report-content="com.woltlab.wcf.article"
-								data-object-id="{$articleContent->articleID}"
-							>
-								{icon name='triangle-exclamation'}
-								<span class="invisible">{lang}wcf.moderation.report.reportContent{/lang}</span>
-							</button>
-						</li>
+						<button
+							type="button"
+							class="button jsTooltip"
+							title="{lang}wcf.moderation.report.reportContent{/lang}"
+							data-report-content="com.woltlab.wcf.article"
+							data-object-id="{$articleContent->articleID}"
+						>
+							{icon name='triangle-exclamation'}
+						</button>
 					{/if}
 					{if MODULE_LIKE && ARTICLE_ENABLE_LIKE && $__wcf->session->getPermission('user.like.canLike') && $article->userID != $__wcf->user->userID}
-						<li role="presentation">
-							<button
-								type="button"
-								role="menuitem"
-								class="button jsTooltip reactButton{if $articleLikeData[$article->articleID]|isset && $articleLikeData[$article->articleID]->reactionTypeID} active{/if}"
-								title="{lang}wcf.reactions.react{/lang}"
-								data-reaction-type-id="{if $articleLikeData[$article->articleID]|isset && $articleLikeData[$article->articleID]->reactionTypeID}{$articleLikeData[$article->articleID]->reactionTypeID}{else}0{/if}"
-							>
-								{icon name='face-smile'} <span class="invisible">{lang}wcf.reactions.react{/lang}</span>
-							</button>
-						</li>
+						<button
+							type="button"
+							class="button jsTooltip reactButton{if $articleLikeData[$article->articleID]|isset && $articleLikeData[$article->articleID]->reactionTypeID} active{/if}"
+							title="{lang}wcf.reactions.react{/lang}"
+							data-reaction-type-id="{if $articleLikeData[$article->articleID]|isset && $articleLikeData[$article->articleID]->reactionTypeID}{$articleLikeData[$article->articleID]->reactionTypeID}{else}0{/if}"
+						>
+							{icon name='face-smile'}
+						</button>
 					{/if}
 
 					{event name='articleLikeButtons'}{* deprecated: use footerButtons instead *}
 					{event name='articleButtons'}{* deprecated: use footerButtons instead *}
 					{event name='footerButtons'}
 				{/content}
-			</ul>
+			</div>
 		{/hascontent}
 	</footer>
 </div>

com.woltlab.wcf/templates/entryTags.tpl

@@ -3,7 +3,7 @@
 		<ul class="tagList">
 			{foreach from=$tags item=tag}
 				<li>
-					<a href="{link controller='Tagged' object=$tag}objectType={$objectType}{/link}" class="tag">
+					<a href="{link controller='Tagged' object=$tag objectType=$objectType}{/link}" class="tag">
 						{icon name='tag'}
 						{$tag->name}
 					</a>

wcfsetup/install/files/lib/system/listView/AbstractListView.class.php

@@ -42,7 +42,7 @@ abstract class AbstractListView
     private bool $allowFiltering = true;
     private bool $allowSorting = true;
     private bool $allowInteractions = true;
-    private int $maxItems = 0;
+    private int $fixedNumberOfItems = 0;
 
     /**
      * @var array<string, string>
@@ -86,19 +86,19 @@ public function setItemsPerPage(int $itemsPerPage): void
     }
 
     /**
-     * Gets the maximum number of items shown.
+     * Gets the fixed number of items shown.
      */
-    public function getMaxItems(): int
+    public function getFixedNumberOfItems(): int
     {
-        return $this->maxItems;
+        return $this->fixedNumberOfItems;
     }
 
     /**
      * Sets the maximum number of items shown.
      */
-    public function setMaxItems(int $maxItems): void
+    public function setFixedNumberOfItems(int $fixedNumberOfItems): void
     {
-        $this->maxItems = $maxItems;
+        $this->fixedNumberOfItems = $fixedNumberOfItems;
     }
 
     /**
@@ -199,8 +199,8 @@ public function getBaseUrl(): string
     protected function initObjectList(): void
     {
         $this->objectList = $this->createObjectList();
-        $this->objectList->sqlLimit = $this->getMaxItems() ?: $this->getItemsPerPage();
-        if (!$this->getMaxItems()) {
+        $this->objectList->sqlLimit = $this->getFixedNumberOfItems() ?: $this->getItemsPerPage();
+        if (!$this->getFixedNumberOfItems()) {
             $this->objectList->sqlOffset = ($this->getPageNo() - 1) * $this->getItemsPerPage();
         }
         if ($this->getSortField()) {
@@ -262,8 +262,8 @@ public function countItems(): int
     {
         if (!isset($this->objectCount)) {
             $this->objectCount = $this->getObjectList()->countObjects();
-            if ($this->getMaxItems() && $this->getMaxItems() < $this->objectCount) {
-                $this->objectCount = $this->getMaxItems();
+            if ($this->getFixedNumberOfItems() && $this->getFixedNumberOfItems() < $this->objectCount) {
+                $this->objectCount = $this->getFixedNumberOfItems();
             }
         }
 

wcfsetup/install/files/style/ui/entry.scss

@@ -43,9 +43,28 @@
 }
 
 .entry__footerButtons {
+	display: flex;
+	gap: 1px;
+	flex-wrap: wrap;
 	margin-inline-start: auto;
 }
 
+.entry__footerButtons .button {
+	padding: 6px 8px;
+
+	@include wcfFontSmall;
+}
+
+.entry__footerButtons .button:not(:first-child) {
+	border-top-left-radius: 0;
+	border-bottom-left-radius: 0;
+}
+
+.entry__footerButtons .button:not(:last-child) {
+	border-top-right-radius: 0;
+	border-bottom-right-radius: 0;
+}
+
 .entry__aboutAuthor {
 	display: flex;
 	gap: 20px;