Remove unnecessary assertions

Author: dtdesign

ts/WoltLabSuite/Core/Acp/Ui/Box/Handler.ts

@@ -155,7 +155,7 @@ class AcpUiBoxHandler {
 
     UiPageSearchHandler.open(
       this.activePageId,
-      selectedOption.textContent!.trim(),
+      selectedOption.textContent.trim(),
       (objectId) => {
         this.pageObjectId.value = objectId.toString();
         this.cache.set(this.activePageId, objectId);

ts/WoltLabSuite/Core/Acp/Ui/Maintenance/RebuildData.ts

@@ -34,13 +34,13 @@ export async function runAllWorkers(): Promise<void> {
 
   let i = 1;
   for (const worker of sorted) {
-    await runWorker(worker, `${worker.textContent!} (${i++} / ${sorted.length})`, true);
+    await runWorker(worker, `${worker.textContent} (${i++} / ${sorted.length})`, true);
   }
 }
 
 async function runWorker(
   button: HTMLElement,
-  dialogTitle: string = button.textContent!,
+  dialogTitle: string = button.textContent,
   implicitContinue = false,
 ): Promise<void> {
   return new Promise<void>((resolve, reject) => {

ts/WoltLabSuite/Core/Acp/Ui/Menu/Item/Handler.ts

@@ -46,7 +46,7 @@ export class AcpUiMenuItemHandler {
 
     UiPageSearchHandler.open(
       parseInt(selectedOption.value),
-      selectedOption.textContent!.trim(),
+      selectedOption.textContent.trim(),
       (objectId) => {
         this.#pageObjectId.value = objectId.toString();
       },

ts/WoltLabSuite/Core/Acp/Ui/Page/Menu/Main/Backend.ts

@@ -11,7 +11,7 @@ import { MenuItem, PageMenuMainProvider } from "../../../../../Ui/Page/Menu/Main
 function getSubMenuItems(subMenu: HTMLElement, menuItem: string): MenuItem[] {
   const categoryList = subMenu.querySelector(`.acpPageSubMenuCategoryList[data-menu-item="${menuItem}"]`)!;
   return Array.from(categoryList.querySelectorAll(".acpPageSubMenuCategory")).map((category: HTMLOListElement) => {
-    const title = category.querySelector("span")!.textContent!;
+    const title = category.querySelector("span")!.textContent;
     const children = getMenuItems(category);
 
     return {
@@ -41,7 +41,7 @@ function getMenuItems(category: HTMLOListElement): MenuItem[] {
       depth: 2,
       identifier: null,
       link: link.href,
-      title: link.textContent!,
+      title: link.textContent,
     };
   });
 }
@@ -73,7 +73,7 @@ export class AcpUiPageMenuMainBackend implements PageMenuMainProvider {
     const menuItems: MenuItem[] = Array.from(menu.querySelectorAll(".acpPageMenuLink")).map(
       (button: HTMLButtonElement) => {
         const menuItem = button.dataset.menuItem!;
-        const title = button.querySelector(".acpPageMenuItemLabel")!.textContent!;
+        const title = button.querySelector(".acpPageMenuItemLabel")!.textContent;
         const children = getSubMenuItems(subMenu, menuItem);
         let icon = button.querySelector("fa-icon") ?? undefined;
         if (icon) {

ts/WoltLabSuite/Core/Bbcode/Code.ts

@@ -99,7 +99,7 @@ class Code {
     }
 
     const container = document.createElement("div");
-    container.innerHTML = Prism.highlight(this.codeContainer.textContent!, grammar, this.language);
+    container.innerHTML = Prism.highlight(this.codeContainer.textContent, grammar, this.language);
 
     // Step 3) Insert the highlighted lines into the page.
     // This is performed in small chunks to prevent the UI thread from being blocked for complex

ts/WoltLabSuite/Core/Clipboard.ts

@@ -15,5 +15,5 @@ export async function copyTextToClipboard(text: string): Promise<void> {
 }
 
 export async function copyElementTextToClipboard(element: HTMLElement): Promise<void> {
-  return copyTextToClipboard(element.textContent!.replace(/\u200B/g, "").replace(/\u00A0/g, " "));
+  return copyTextToClipboard(element.textContent.replace(/\u200B/g, "").replace(/\u00A0/g, " "));
 }

ts/WoltLabSuite/Core/Component/Dialog/Setup.ts

@@ -41,7 +41,7 @@ export class DialogSetup {
 
   fromHtml(html: string): DialogControls {
     const fragment = DomUtil.createFragmentFromHtml(html);
-    if (fragment.childElementCount === 0 && fragment.textContent!.trim() === "") {
+    if (fragment.childElementCount === 0 && fragment.textContent.trim() === "") {
       throw new TypeError("The provided HTML string was empty.");
     }
 

ts/WoltLabSuite/Core/Component/GoogleMaps/MarkerLoader.ts

@@ -120,7 +120,7 @@ class MarkerLoader {
             if (!dialog) {
               dialog = dialogFactory().fromHtml(data.dialog!).withoutControls();
             }
-            dialog.show(button.dataset.title || button.textContent!);
+            dialog.show(button.dataset.title || button.textContent);
           });
         });
       }

ts/WoltLabSuite/Core/Component/Quote/Message.ts

@@ -307,7 +307,7 @@ function getNodeText(node: Node): string {
 
     if (node instanceof HTMLAnchorElement) {
       // \u2026 === …
-      const value = node.textContent!;
+      const value = node.textContent;
       if (value.indexOf("\u2026") > 0) {
         const tmp = value.split(/\u2026/);
         if (tmp.length === 2) {

ts/WoltLabSuite/Core/Date/Picker.ts

@@ -552,7 +552,7 @@ function renderGrid(day?: number, month?: number, year?: number): void {
     for (let i = 0; i < 37; i++) {
       const cell = _dateCells[i];
 
-      let active = +cell.textContent! === day;
+      let active = +cell.textContent === day;
       if (cell.classList.contains("otherMonth") || cell.classList.contains("disabled")) {
         active = false;
       }
@@ -625,7 +625,7 @@ function click(event: MouseEvent): void {
 
   _input!.dataset.empty = "false";
 
-  renderGrid(+target.textContent!);
+  renderGrid(+target.textContent);
 
   const data = _data.get(_input!) as DatePickerData;
   if (!data.isDateTime) {