Check whether the user is null directly in handle() and expect a not nullable UserProfile in assertUserCanBeManaged()

Author: Cyperghost

wcfsetup/install/files/lib/action/UserBanAction.class.php

@@ -37,7 +37,7 @@ protected function performAction(UserProfile $userProfile, array $data): void
     }
 
     #[\Override]
-    protected function assertUserCanBeManaged(?UserProfile $userProfile): void
+    protected function assertUserCanBeManaged(UserProfile $userProfile): void
     {
         parent::assertUserCanBeManaged($userProfile);
 

wcfsetup/install/files/lib/action/UserDisableAvatarAction.class.php

@@ -37,7 +37,7 @@ protected function performAction(UserProfile $userProfile, array $data): void
     }
 
     #[\Override]
-    protected function assertUserCanBeManaged(?UserProfile $userProfile): void
+    protected function assertUserCanBeManaged(UserProfile $userProfile): void
     {
         parent::assertUserCanBeManaged($userProfile);
 

wcfsetup/install/files/lib/action/UserDisableCoverPhotoAction.class.php

@@ -37,7 +37,7 @@ protected function performAction(UserProfile $userProfile, array $data): void
     }
 
     #[\Override]
-    protected function assertUserCanBeManaged(?UserProfile $userProfile): void
+    protected function assertUserCanBeManaged(UserProfile $userProfile): void
     {
         parent::assertUserCanBeManaged($userProfile);
 

wcfsetup/install/files/lib/action/UserDisableSignatureAction.class.php

@@ -37,7 +37,7 @@ protected function performAction(UserProfile $userProfile, array $data): void
     }
 
     #[\Override]
-    protected function assertUserCanBeManaged(?UserProfile $userProfile): void
+    protected function assertUserCanBeManaged(UserProfile $userProfile): void
     {
         parent::assertUserCanBeManaged($userProfile);
 

wcfsetup/install/files/lib/action/UserManagementAction.class.php

@@ -36,6 +36,11 @@ public function handle(ServerRequestInterface $request): ResponseInterface
         );
 
         $user = UserProfileRuntimeCache::getInstance()->getObject($parameters['id']);
+
+        if (!$user) {
+            throw new IllegalLinkException();
+        }
+
         $this->assertUserCanBeManaged($user);
 
         $form = $this->getForm();
@@ -58,12 +63,8 @@ public function handle(ServerRequestInterface $request): ResponseInterface
         }
     }
 
-    protected function assertUserCanBeManaged(?UserProfile $userProfile): void
+    protected function assertUserCanBeManaged(UserProfile $userProfile): void
     {
-        if (!$userProfile) {
-            throw new IllegalLinkException();
-        }
-
         if ($userProfile->userID === WCF::getUser()->userID) {
             throw new IllegalLinkException();
         }