Fix various linting issues

Author: dtdesign

ts/WoltLabSuite/Core/Ajax/Backend.ts

@@ -98,7 +98,7 @@ class BackendRequest {
     let json: unknown;
     try {
       json = await response.json();
-    } catch (e) {
+    } catch {
       throw new InvalidJson(response);
     }
 

ts/WoltLabSuite/Core/Ajax/DboAction.ts

@@ -217,7 +217,7 @@ async function tryParseAsJson(response: Response): Promise<ResponseData> {
   let json: ResponseData;
   try {
     json = await response.json();
-  } catch (e) {
+  } catch {
     throw new InvalidJson(response);
   }
 

ts/WoltLabSuite/Core/Ajax/Error.ts

@@ -60,7 +60,7 @@ async function getErrorHtml(error: ApiError): Promise<string | HTMLIFrameElement
       let json: ErrorResponse | undefined = undefined;
       try {
         json = await error.response.clone().json();
-      } catch (e) {
+      } catch {
         message = await error.response.clone().text();
       }
 

ts/WoltLabSuite/Core/Ajax/Request.ts

@@ -235,7 +235,7 @@ class AjaxRequest {
       if (this.getContentType(xhr) === "application/json") {
         try {
           data = JSON.parse(xhr.responseText) as ResponseData;
-        } catch (e) {
+        } catch {
           // invalid JSON
           this._failure(xhr, options);
 
@@ -275,7 +275,7 @@ class AjaxRequest {
     let data: ResponseData | null = null;
     try {
       data = JSON.parse(xhr.responseText);
-    } catch (e) {
+    } catch {
       // Ignore JSON parsing failure.
     }
 

ts/WoltLabSuite/Core/Bbcode/Code.ts

@@ -115,7 +115,7 @@ class Code {
       const chunkEnd = Math.min(chunkStart + Code.chunkSize, max);
 
       for (let offset = chunkStart; offset < chunkEnd; offset++) {
-        const toReplace = originalLines[offset]!;
+        const toReplace = originalLines[offset];
         const replacement = highlightedLines.next().value as Element;
         toReplace.parentNode!.replaceChild(replacement, toReplace);
       }

ts/WoltLabSuite/Core/Component/Comment/List.ts

@@ -126,7 +126,7 @@ class CommentList {
     } catch (error) {
       await handleValidationErrors(error, () => {
         // The comment id is invalid or there is a mismatch, silently ignore it.
-        permaLinkComment!.remove();
+        permaLinkComment.remove();
 
         return true;
       });
@@ -195,7 +195,7 @@ class CommentList {
     } catch (error) {
       await handleValidationErrors(error, () => {
         // The response id is invalid or there is a mismatch, silently ignore it.
-        permalinkResponse!.remove();
+        permalinkResponse.remove();
 
         return true;
       });

ts/WoltLabSuite/Core/Controller/Popover.ts

@@ -325,8 +325,8 @@ class ControllerPopover implements AjaxCallbackObject {
     if (forceHide) {
       this.popover.classList.add("forceHide");
 
-      // force layout
-      //noinspection BadExpressionStatementJS
+      // Query a layout related property to force a reflow, otherwise the transition is optimized away.
+      // eslint-disable-next-line @typescript-eslint/no-unused-expressions
       this.popover.offsetTop;
 
       this.clearContent();

ts/WoltLabSuite/Core/Devtools.ts

@@ -87,7 +87,7 @@ const Devtools = {
           if (settings !== null) {
             _settings = JSON.parse(settings);
           }
-        } catch (e) {
+        } catch {
           // Ignore JSON parsing failure.
         }
 

ts/WoltLabSuite/Core/Form/Builder/Field/Checkboxes.ts

@@ -29,7 +29,7 @@ class Checkboxes extends Field {
 
         return null;
       })
-      .filter((v) => v !== null) as string[];
+      .filter((v) => v !== null);
 
     return {
       [this._fieldId]: values,

ts/WoltLabSuite/Core/Image/ExifUtil.ts

@@ -55,7 +55,11 @@ async function blobToUint8(blob: Blob | File): Promise<Uint8Array> {
 
     reader.addEventListener("error", () => {
       reader.abort();
-      reject(reader.error);
+      if (reader.error) {
+        reject(reader.error);
+      } else {
+        reject();
+      }
     });
 
     reader.addEventListener("load", () => {