Fix level 3 errors

Author: dtdesign

phpstan-baseline.neon

@@ -2,7 +2,7 @@ includes:
     - phpstan-baseline.neon
 
 parameters:
-    level: 2
+    level: 3
     paths:
         - wcfsetup/install/files
     excludePaths:

phpstan.neon

@@ -38,7 +38,7 @@ abstract class AbstractCustomOptionForm extends AbstractAcpForm
 
     /**
      * option default value
-     * @var string
+     * @var string|int|float
      */
     public $defaultValue = '';
 
@@ -56,7 +56,7 @@ abstract class AbstractCustomOptionForm extends AbstractAcpForm
 
     /**
      * field is required
-     * @var bool
+     * @var int
      */
     public $required = 0;
 
@@ -68,7 +68,7 @@ abstract class AbstractCustomOptionForm extends AbstractAcpForm
 
     /**
      * 1 if the option is disabled
-     * @var bool
+     * @var int
      * @since   5.2
      */
     public $isDisabled = 0;

wcfsetup/install/files/lib/acp/form/AbstractCustomOptionForm.class.php

@@ -70,7 +70,7 @@ class AdAddForm extends AbstractForm
 
     /**
      * list of available locations
-     * @var string[]
+     * @var array<string, array<int, string>>
      */
     public $locations = [];
 

wcfsetup/install/files/lib/acp/form/AdAddForm.class.php

@@ -59,7 +59,7 @@ class ArticleAddForm extends AbstractForm
 
     /**
      * true if created article is multi-lingual
-     * @var bool
+     * @var int
      */
     public $isMultilingual = 0;
 
@@ -113,7 +113,7 @@ class ArticleAddForm extends AbstractForm
 
     /**
      * enables the comment function
-     * @var bool
+     * @var int
      */
     public $enableComments = ARTICLE_ENABLE_COMMENTS_DEFAULT_VALUE;
 
@@ -587,7 +587,7 @@ public function save()
         $this->categoryID = 0;
         $this->publicationStatus = Article::PUBLISHED;
         $this->enableComments = ARTICLE_ENABLE_COMMENTS_DEFAULT_VALUE;
-        $this->title = $this->teaser = $this->content = $this->images = $this->imageID = $this->teaserImages = $this->teaserImageID == $this->tags = [];
+        $this->title = $this->teaser = $this->content = $this->images = $this->imageID = $this->teaserImages = $this->teaserImageID = $this->tags = [];
         $this->metaTitle = $this->metaDescription = [];
 
         // Reload attachment handler to reset the uploaded attachments.

wcfsetup/install/files/lib/acp/form/ArticleAddForm.class.php

@@ -183,10 +183,10 @@ public function readData()
             $this->bbcodeTag = $this->bbcode->bbcodeTag;
             $this->htmlOpen = $this->bbcode->htmlOpen;
             $this->htmlClose = $this->bbcode->htmlClose;
-            $this->isBlockElement = $this->bbcode->isBlockElement;
-            $this->isSourceCode = $this->bbcode->isSourceCode;
+            $this->isBlockElement = !!$this->bbcode->isBlockElement;
+            $this->isSourceCode = !!$this->bbcode->isSourceCode;
             $this->className = $this->bbcode->className;
-            $this->showButton = $this->bbcode->showButton;
+            $this->showButton = !!$this->bbcode->showButton;
             $this->wysiwygIcon = $this->bbcode->wysiwygIcon;
         }
     }

wcfsetup/install/files/lib/acp/form/BBCodeEditForm.class.php

@@ -53,7 +53,7 @@ class BoxAddForm extends AbstractForm
 
     /**
      * true if created box is multi-lingual
-     * @var bool
+     * @var int
      */
     public $isMultilingual = 0;
 
@@ -77,7 +77,7 @@ class BoxAddForm extends AbstractForm
 
     /**
      * true if created box is visible everywhere
-     * @var bool
+     * @var int
      */
     public $visibleEverywhere = 1;
 
@@ -89,7 +89,7 @@ class BoxAddForm extends AbstractForm
 
     /**
      * true if box header is visible
-     * @var bool
+     * @var int
      */
     public $showHeader = 1;
 
@@ -137,7 +137,7 @@ class BoxAddForm extends AbstractForm
 
     /**
      * selected box controller object type
-     * @var ObjectType
+     * @var ?ObjectType
      */
     public $boxController;
 
@@ -200,7 +200,7 @@ class BoxAddForm extends AbstractForm
     public $availableBoxPositions = [];
 
     /**
-     * @var bool
+     * @var int
      * @since   5.2
      */
     public $isDisabled = 0;
@@ -218,7 +218,7 @@ class BoxAddForm extends AbstractForm
     public $presetBox;
 
     /**
-     * @var bool
+     * @var int
      * @since   5.4
      */
     public $invertPermissions;
@@ -480,13 +480,13 @@ public function validate()
                 }
             }
         } elseif ($this->boxType !== 'system' && $this->linkType == 'external') {
-            $this->linkPageID = $this->linkPageObjectID = null;
+            $this->linkPageID = $this->linkPageObjectID = 0;
 
             if (empty($this->externalURL)) {
                 throw new UserInputException('externalURL');
             }
         } else {
-            $this->linkPageID = $this->linkPageObjectID = null;
+            $this->linkPageID = $this->linkPageObjectID = 0;
             $this->externalURL = '';
         }
 

wcfsetup/install/files/lib/acp/form/BoxAddForm.class.php

@@ -175,7 +175,7 @@ public function save()
         ]);
 
         // reset values
-        $this->email = $this->name = 0;
+        $this->email = $this->name = '';
         $this->isDisabled = $this->showOrder = 0;
 
         I18nHandler::getInstance()->reset();

wcfsetup/install/files/lib/acp/form/ContactRecipientAddForm.class.php

@@ -45,7 +45,7 @@ class NotificationPresetSettingsForm extends AbstractForm
 
     /**
      * true to apply change to existing users
-     * @var bool
+     * @var int
      */
     public $applyChangesToExistingUsers = 0;
 

wcfsetup/install/files/lib/acp/form/NotificationPresetSettingsForm.class.php

@@ -42,7 +42,7 @@ class PackageStartInstallForm extends AbstractForm
      * data of the uploaded package
      * @var string[]
      */
-    public $uploadPackage = '';
+    public $uploadPackage = [];
 
     /**
      * archive of the installation/update package