Skip to content

Commit b4ce062

Browse files
committed
Improve the type safety of form builder forms
1 parent b1858de commit b4ce062

36 files changed

+61
-19
lines changed

wcfsetup/install/files/lib/acp/form/BBCodeMediaProviderAddForm.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
* @copyright 2001-2024 WoltLab GmbH
2424
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
2525
*
26-
* @property BBCodeMediaProvider $formObjects
26+
* @extends AbstractFormBuilderForm<BBCodeMediaProvider>
2727
*/
2828
class BBCodeMediaProviderAddForm extends AbstractFormBuilderForm
2929
{

wcfsetup/install/files/lib/acp/form/CaptchaQuestionAddForm.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* @copyright 2001-2024 WoltLab GmbH
2323
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
2424
*
25-
* @property CaptchaQuestion $formObject
25+
* @extends AbstractFormBuilderForm<CaptchaQuestion>
2626
*/
2727
class CaptchaQuestionAddForm extends AbstractFormBuilderForm
2828
{

wcfsetup/install/files/lib/acp/form/CategoryAddFormBuilderForm.class.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@
4141
* @copyright 2001-2023 WoltLab GmbH
4242
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
4343
* @since 6.1
44+
*
45+
* @extends AbstractFormBuilderForm<Category>
4446
*/
4547
abstract class CategoryAddFormBuilderForm extends AbstractFormBuilderForm
4648
{
@@ -455,7 +457,6 @@ public function saved()
455457
$category = $this->objectAction->getReturnValues()['returnValues'];
456458
\assert($category instanceof Category);
457459
} else {
458-
// @phpstan-ignore property.notFound
459460
$category = new Category($this->formObject->categoryID);
460461
}
461462

@@ -513,7 +514,6 @@ protected function checkCategoryPermissions(): void
513514
$processor = $this->getObjectTypeProcessor();
514515

515516
if ($this->formObject instanceof DatabaseObject) {
516-
// @phpstan-ignore property.notFound
517517
if ($this->formObject->objectTypeID !== $this->objectType->getObjectID()) {
518518
throw new IllegalLinkException();
519519
}

wcfsetup/install/files/lib/acp/form/CronjobAddForm.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
* @copyright 2001-2024 WoltLab GmbH
2424
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
2525
*
26-
* @property Cronjob $formObject
26+
* @extends AbstractFormBuilderForm<Cronjob>
2727
*/
2828
class CronjobAddForm extends AbstractFormBuilderForm
2929
{

wcfsetup/install/files/lib/acp/form/DevtoolsProjectAddForm.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
4545
* @since 3.1
4646
*
47-
* @property null|DevtoolsProject $formObject
47+
* @extends AbstractFormBuilderForm<DevtoolsProject>
4848
*/
4949
class DevtoolsProjectAddForm extends AbstractFormBuilderForm
5050
{

wcfsetup/install/files/lib/acp/form/DevtoolsProjectPipEntryAddForm.class.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
* @copyright 2001-2019 WoltLab GmbH
2222
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
2323
* @since 5.2
24+
*
25+
* @extends AbstractFormBuilderForm<null>
2426
*/
2527
class DevtoolsProjectPipEntryAddForm extends AbstractFormBuilderForm
2628
{

wcfsetup/install/files/lib/acp/form/FirstTimeSetupLicenseForm.class.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
* @copyright 2001-2023 WoltLab GmbH
3232
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
3333
* @since 6.0
34+
*
35+
* @extends AbstractFormBuilderForm<null>
3436
*/
3537
final class FirstTimeSetupLicenseForm extends AbstractFormBuilderForm
3638
{

wcfsetup/install/files/lib/acp/form/LabelAddForm.class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* @copyright 2001-2024 WoltLab GmbH
2323
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
2424
*
25-
* @property Label $formObject
25+
* @extends AbstractFormBuilderForm<Label>
2626
*/
2727
class LabelAddForm extends AbstractFormBuilderForm
2828
{

wcfsetup/install/files/lib/acp/form/LanguageAddForm.class.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
* @author Florian Gail, Marcel Werk
2424
* @copyright 2001-2023 WoltLab GmbH
2525
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
26+
*
27+
* @extends AbstractFormBuilderForm<Language>
2628
*/
2729
class LanguageAddForm extends AbstractFormBuilderForm
2830
{

wcfsetup/install/files/lib/acp/form/LanguageItemAddForm.class.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace wcf\acp\form;
44

55
use wcf\data\language\category\LanguageCategoryList;
6+
use wcf\data\language\item\LanguageItem;
67
use wcf\data\language\item\LanguageItemAction;
78
use wcf\data\language\item\LanguageItemList;
89
use wcf\form\AbstractFormBuilderForm;
@@ -26,6 +27,8 @@
2627
* @copyright 2001-2019 WoltLab GmbH
2728
* @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
2829
* @since 5.2
30+
*
31+
* @extends AbstractFormBuilderForm<LanguageItem>
2932
*/
3033
class LanguageItemAddForm extends AbstractFormBuilderForm
3134
{

0 commit comments

Comments
 (0)