Strip the transactions

These were used as a performance improvement in old MySQL versions and are not really needed anymore. Plus they make it more likely to run into deadlocks when used with large numbers of recipients.

See https://www.woltlab.com/community/thread/314371/

Author: dtdesign

wcfsetup/install/files/lib/data/user/notification/UserNotificationAction.class.php

@@ -56,15 +56,13 @@ public function createDefault()
                 VALUES      (?, ?, ?)";
         $statement = WCF::getDB()->prepare($sql);
 
-        WCF::getDB()->beginTransaction();
         foreach ($notifications as $notificationData) {
             $statement->execute([
                 $notificationData['object']->notificationID,
                 $this->parameters['authorID'] ?: null,
                 TIME_NOW,
             ]);
         }
-        WCF::getDB()->commitTransaction();
 
         return $notifications;
     }
@@ -128,7 +126,6 @@ public function createStackable()
                 WHERE   notificationID = ?";
         $triggerStatement = WCF::getDB()->prepare($sql);
 
-        WCF::getDB()->beginTransaction();
         $notificationIDs = [];
         foreach ($notifications as $notificationData) {
             $notificationIDs[] = $notificationData['object']->notificationID;
@@ -144,7 +141,6 @@ public function createStackable()
                 $notificationData['object']->notificationID,
             ]);
         }
-        WCF::getDB()->commitTransaction();
 
         $notificationList = new UserNotificationList();
         $notificationList->setObjectIDs($notificationIDs);