Align the details of the benchmark’s stacktrace with the exceptions

This is now in line with the exceptions and makes it clear where a call happens.

This was previously quite confusing because the line is where the call in the file (!) took place that invoked said method. The line refers to the callee and not to a line within the class being listed.

Author: dtdesign

com.woltlab.wcf/templates/shared_benchmark.tpl

@@ -24,7 +24,17 @@
 							<ol class="nativeList" start="0">
 								{foreach from=$item.trace item=traceItem}
 									<li>
-										{if !$traceItem.class|empty}{$traceItem.class}{$traceItem.type}{else}{if !$traceItem.file|empty}{$traceItem.file}: {/if}{/if}{$traceItem.function}() {if !$traceItem.line|empty}(line {#$traceItem.line}){/if}
+										{if !$traceItem.class|empty}{*
+											*}{$traceItem.class}{$traceItem.type}{*
+										*}{elseif !$traceItem.file|empty}{*
+											*}{$traceItem.file}: {*
+										*}{/if}{*
+										*}{$traceItem.function}()
+										<span class="benchmark__stacktrace__context">
+										{$traceItem[file]}{if !$traceItem.line|empty}{*
+											*}:{#$traceItem.line}{*
+										*}{/if}
+										</span>
 									</li>
 								{/foreach}
 							</ol>

wcfsetup/install/files/lib/system/benchmark/Benchmark.class.php

@@ -115,6 +115,17 @@ static function ($index) use ($startOfMiddleware, $endOfMiddleware) {
             );
         }
 
+        foreach ($backtrace as &$segment) {
+            if (!isset($segment['file'])) {
+                continue;
+            }
+
+            if (preg_match('~^(' . preg_quote($_SERVER['DOCUMENT_ROOT'], '~') . '|' . preg_quote(WCF_DIR, '~') . ')~', $segment['file'])) {
+                $segment['file'] = '*/' . FileUtil::removeTrailingSlash(FileUtil::getRelativePath(WCF_DIR, $segment['file']));
+            }
+        }
+        unset($segment);
+
         $this->items[$newIndex]['trace'] = $backtrace;
 
         return $newIndex;

wcfsetup/install/files/style/ui/benchmark.scss

@@ -1,3 +1,10 @@
 .benchmarkDetails .hot {
 	color: var(--wcfStatusErrorText);
 }
+
+.benchmark__stacktrace__context {
+	color: var(--wcfContentDimmedText);
+	display: block;
+	
+	@include wcfFontSmall;
+}