Remove the member $languageID from UserRankCache

Author: Cyperghost

wcfsetup/install/files/lib/data/user/UserProfile.class.php

@@ -18,7 +18,6 @@
 use wcf\data\user\online\UserOnline;
 use wcf\data\user\option\ViewableUserOption;
 use wcf\data\user\rank\UserRank;
-use wcf\data\user\rank\ViewableUserRank;
 use wcf\system\cache\builder\UserGroupPermissionCacheBuilder;
 use wcf\system\cache\eager\UserRankCache;
 use wcf\system\cache\runtime\FileRuntimeCache;
@@ -930,7 +929,7 @@ public function getUserTitle()
         return '';
     }
 
-    public function getRank(): ?ViewableUserRank
+    public function getRank(): ?UserRank
     {
         if (!\MODULE_USER_RANK) {
             return null;
@@ -940,7 +939,7 @@ public function getRank(): ?ViewableUserRank
             return null;
         }
 
-        $userRanks = (new UserRankCache(WCF::getLanguage()->languageID))->getCache();
+        $userRanks = (new UserRankCache())->getCache();
 
         return $userRanks[$this->rankID] ?? null;
     }

wcfsetup/install/files/lib/data/user/rank/UserRankEditor.class.php

@@ -6,7 +6,6 @@
 use wcf\data\IEditableCachedObject;
 use wcf\system\cache\builder\UserRankCacheBuilder;
 use wcf\system\cache\eager\UserRankCache;
-use wcf\system\language\LanguageFactory;
 
 /**
  * Provides functions to edit user ranks.
@@ -33,8 +32,6 @@ public static function resetCache()
     {
         UserRankCacheBuilder::getInstance()->reset();
 
-        foreach (LanguageFactory::getInstance()->getLanguages() as $language) {
-            (new UserRankCache($language->languageID))->rebuild();
-        }
+        (new UserRankCache())->rebuild();
     }
 }

wcfsetup/install/files/lib/system/cache/eager/UserRankCache.class.php

@@ -2,8 +2,8 @@
 
 namespace wcf\system\cache\eager;
 
-use wcf\data\user\rank\ViewableUserRank;
-use wcf\data\user\rank\ViewableUserRankList;
+use wcf\data\user\rank\UserRank;
+use wcf\data\user\rank\UserRankList;
 
 /**
  * Eager cache implementation for user ranks.
@@ -13,19 +13,14 @@
  * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
  * @since 6.2
  *
- * @extends AbstractEagerCache<array<int, ViewableUserRank>>
+ * @extends AbstractEagerCache<array<int, UserRank>>
  */
 final class UserRankCache extends AbstractEagerCache
 {
-    public function __construct(
-        public readonly int $languageID
-    ) {
-    }
-
     #[\Override]
     protected function getCacheData(): array
     {
-        $userRankList = new ViewableUserRankList($this->languageID);
+        $userRankList = new UserRankList();
         $userRankList->readObjects();
 
         return $userRankList->getObjects();