Add new page to manage the conversation labels

Author: Cyperghost

files/js/WoltLabSuite/Core/Conversation/Component/Label/Manager.js

@@ -10,16 +10,14 @@
 use wcf\data\conversation\label\ConversationLabelAction;
 use wcf\data\IStorableObject;
 use wcf\http\Helper;
+use wcf\system\exception\NamedUserException;
 use wcf\system\exception\PermissionDeniedException;
 use wcf\system\form\builder\data\processor\CustomFormDataProcessor;
 use wcf\system\form\builder\field\BadgeColorFormField;
-use wcf\system\form\builder\field\CheckboxFormField;
-use wcf\system\form\builder\field\dependency\EmptyFormFieldDependency;
 use wcf\system\form\builder\field\TextFormField;
 use wcf\system\form\builder\IFormDocument;
 use wcf\system\form\builder\Psr15DialogForm;
 use wcf\system\WCF;
-use wcf\util\StringUtil;
 
 /**
  * Action for adding/editing conversation labels.
@@ -60,7 +58,7 @@ public function handle(ServerRequestInterface $request): ResponseInterface
             \count(ConversationLabel::getLabelsByUser())
             >= WCF::getSession()->getPermission('user.conversation.maxLabels')
         ) {
-            throw new PermissionDeniedException();
+            throw new NamedUserException(WCF::getLanguage()->get('wcf.conversation.label.management.addLabel.maxLabels'));
         }
 
         $form = $this->getForm($label);
@@ -74,36 +72,21 @@ public function handle(ServerRequestInterface $request): ResponseInterface
             }
 
             $data = $form->getData()['data'];
-            $deleteLabel = $label && ($data['deleteLabel'] ?? false);
-            unset($data['deleteLabel']);
-
-            if ($deleteLabel) {
-                (new ConversationLabelAction([$label], 'delete'))->executeAction();
 
-                $labelID = $label->labelID;
-            } elseif ($label) {
+            if ($label) {
                 (new ConversationLabelAction([$label], 'update', [
                     'data' => $data,
                 ]))->executeAction();
-
-                $labelID = $label->labelID;
             } else {
-                $returnValues = (new ConversationLabelAction([], 'create', [
+                (new ConversationLabelAction([], 'create', [
                     'data' => \array_merge($data, [
                         'userID' => WCF::getUser()->userID,
                     ]),
                 ]))->executeAction();
-
-                $labelID = $returnValues['returnValues']->labelID;
             }
 
             return new JsonResponse([
-                'result' => [
-                    'deleteLabel' => $deleteLabel,
-                    'label' => $deleteLabel ? '' : StringUtil::encodeHTML($data['label']),
-                    'cssClassName' => $deleteLabel ? '' : $data['cssClassName'],
-                    'labelID' => $labelID,
-                ],
+                'result' => [],
             ]);
         } else {
             throw new \LogicException('Unreachable');
@@ -118,10 +101,6 @@ private function getForm(?ConversationLabel $label): Psr15DialogForm
                 'labelName' => $label->label,
             ]) : WCF::getLanguage()->get('wcf.conversation.label.management.addLabel')
         );
-        $deleteLabel = CheckboxFormField::create('deleteLabel')
-            ->label('wcf.conversation.label.management.deleteLabel')
-            ->available($label !== null)
-            ->value(false);
         $labelFormField = TextFormField::create('label')
             ->label('wcf.conversation.label.labelName')
             ->required();
@@ -134,20 +113,7 @@ private function getForm(?ConversationLabel $label): Psr15DialogForm
             ->value('none')
             ->required();
 
-        if ($label !== null) {
-            $cssClassNameFormField
-                ->addDependency(
-                    EmptyFormFieldDependency::create('deleteDependency')
-                        ->fieldId('deleteLabel')
-                );
-            $labelFormField->addDependency(
-                EmptyFormFieldDependency::create('deleteDependency')
-                    ->fieldId('deleteLabel')
-            );
-        }
-
         $form->appendChildren([
-            $deleteLabel,
             $labelFormField,
             $cssClassNameFormField,
         ]);

files/lib/action/ConversationLabelFormAction.class.php

@@ -49,6 +49,7 @@ static function (\wcf\event\endpoint\ControllerCollecting $event) {
             $event->register(new \wcf\system\endpoint\controller\core\conversations\RemoveConversationParticipant());
             $event->register(new \wcf\system\endpoint\controller\core\conversations\GetConversationParticipantList());
             $event->register(new \wcf\system\endpoint\controller\core\conversations\GetConversationLabelManager());
+            $event->register(new \wcf\system\endpoint\controller\core\conversations\labels\DeleteConversationLabel());
         }
     );
 };

files/lib/bootstrap/com.woltlab.wcf.conversation.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace wcf\event\gridView\user;
+
+use wcf\event\IPsr14Event;
+use wcf\system\gridView\user\ConversationLabelGridView;
+
+/**
+ * Indicates that the conversation label grid view has been initialized.
+ *
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.2
+ */
+final class ConversationLabelGridViewInitialized implements IPsr14Event
+{
+    public function __construct(public readonly ConversationLabelGridView $param)
+    {
+    }
+}

files/lib/event/gridView/user/ConversationLabelGridViewInitialized.class.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace wcf\event\interaction\user;
+
+use wcf\event\IPsr14Event;
+use wcf\system\interaction\user\ConversationLabelInteractions;
+
+/**
+ * Indicates that the provider for conversation label interactions is collecting interactions.
+ *
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.2
+ */
+final class ConversationLabelInteractionCollecting implements IPsr14Event
+{
+    public function __construct(public readonly ConversationLabelInteractions $param)
+    {
+    }
+}

files/lib/event/interaction/user/ConversationLabelInteractionCollecting.class.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace wcf\page;
+
+use wcf\system\gridView\user\ConversationLabelGridView;
+
+/**
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.2
+ *
+ * @extends AbstractGridViewPage<ConversationLabelGridView>
+ */
+final class ConversationLabelListPage extends AbstractGridViewPage
+{
+    /**
+     * @inheritDoc
+     */
+    public $loginRequired = true;
+
+    #[\Override]
+    protected function createGridView(): ConversationLabelGridView
+    {
+        return new ConversationLabelGridView();
+    }
+}

files/lib/page/ConversationLabelListPage.class.php

@@ -0,0 +1,44 @@
+<?php
+
+namespace wcf\system\endpoint\controller\core\conversations\labels;
+
+use Laminas\Diactoros\Response\JsonResponse;
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\ServerRequestInterface;
+use wcf\data\conversation\label\ConversationLabel;
+use wcf\data\conversation\label\ConversationLabelAction;
+use wcf\http\Helper;
+use wcf\system\endpoint\DeleteRequest;
+use wcf\system\endpoint\IController;
+use wcf\system\exception\PermissionDeniedException;
+use wcf\system\WCF;
+
+/**
+ * API endpoint for delete a conversation label.
+ *
+ * @author Olaf Braun
+ * @copyright 2001-2025 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @since 6.2
+ */
+#[DeleteRequest('/core/conversations/labels/{id:\d+}')]
+final class DeleteConversationLabel implements IController
+{
+    #[\Override]
+    public function __invoke(ServerRequestInterface $request, array $variables): ResponseInterface
+    {
+        $label = Helper::fetchObjectFromRequestParameter($variables['id'], ConversationLabel::class);
+        $this->assertLabelCanBeDeleted($label);
+
+        (new ConversationLabelAction([$label], 'delete'))->executeAction();
+
+        return new JsonResponse([]);
+    }
+
+    private function assertLabelCanBeDeleted(ConversationLabel $label): void
+    {
+        if ($label->userID !== WCF::getUser()->userID) {
+            throw new PermissionDeniedException();
+        }
+    }
+}