Apply suggestions from code review

Cyperghost · BurntimeX · web-flow · commit e3c652e5a6b2 · 2025-06-30T16:18:13.000+02:00
Co-authored-by: Marcel Werk &lt;burntime@woltlab.com&gt;
diff --git a/files/lib/data/conversation/label/ConversationLabel.class.php b/files/lib/data/conversation/label/ConversationLabel.class.php
@@ -68,7 +68,7 @@ public static function getLabelCssClassNames()
 
     public function render(): string
     {
-        $cssClassName = $this->cssClassName ? ' ' . $this->cssClassName : '';
+        $cssClassName = StringUtil::encodeHTML($this->cssClassName ? ' ' . $this->cssClassName : '');
         $title = StringUtil::encodeHTML($this->label);
 
         return <<<HTML
diff --git a/files/lib/event/interaction/bulk/user/ConversationBulkInteractionCollecting.class.php b/files/lib/event/interaction/bulk/user/ConversationBulkInteractionCollecting.class.php
@@ -15,7 +15,7 @@
  */
 final class ConversationBulkInteractionCollecting implements IPsr14Event
 {
-    public function __construct(public readonly ConversationBulkInteractions $param)
+    public function __construct(public readonly ConversationBulkInteractions $provider)
     {
     }
 }
diff --git a/files/lib/event/interaction/user/ConversationInteractionCollecting.class.php b/files/lib/event/interaction/user/ConversationInteractionCollecting.class.php
@@ -15,7 +15,7 @@
  */
 final class ConversationInteractionCollecting implements IPsr14Event
 {
-    public function __construct(public readonly ConversationInteractions $param)
+    public function __construct(public readonly ConversationInteractions $provider)
     {
     }
 }
diff --git a/files/lib/event/listView/user/ConversationListViewInitialized.class.php b/files/lib/event/listView/user/ConversationListViewInitialized.class.php
@@ -15,7 +15,7 @@
  */
 final class ConversationListViewInitialized implements IPsr14Event
 {
-    public function __construct(public readonly ConversationListView $param)
+    public function __construct(public readonly ConversationListView $provider)
     {
     }
 }
diff --git a/templates/conversationContentHeaderTitle.tpl b/templates/conversationContentHeaderTitle.tpl
@@ -1,5 +1,5 @@
 <div class="contentHeaderTitle">
-	<h1 class="contentTitle jsConversationSubject" data-conversation-id="{$conversation->conversationID}">{$conversation->subject}</h1>
+	<h1 class="contentTitle">{$conversation->subject}</h1>
 
 	<ul class="inlineList contentHeaderMetaData">
 		{hascontent}

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public static function getLabelCssClassNames()`
`68`	`68`
`69`	`69`	`public function render(): string`
`70`	`70`	`{`
`71`		`- $cssClassName = $this->cssClassName ? ' ' . $this->cssClassName : '';`
	`71`	`+ $cssClassName = StringUtil::encodeHTML($this->cssClassName ? ' ' . $this->cssClassName : '');`
`72`	`72`	`$title = StringUtil::encodeHTML($this->label);`
`73`	`73`
`74`	`74`	`return <<<HTML`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`*/`
`16`	`16`	`final class ConversationBulkInteractionCollecting implements IPsr14Event`
`17`	`17`	`{`
`18`		`- public function __construct(public readonly ConversationBulkInteractions $param)`
	`18`	`+ public function __construct(public readonly ConversationBulkInteractions $provider)`
`19`	`19`	`{`
`20`	`20`	`}`
`21`	`21`	`}`