Skip to content

Commit 8c9713b

Browse files
Cyperghostdtdesign
andauthored
Apply suggestions from code review
Co-authored-by: Alexander Ebert <[email protected]>
1 parent 97e14b1 commit 8c9713b

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

docs/javascript/components_image_viewer.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ The following code example adds an image to the global modal and groups it with
1919

2020
```smarty
2121
<a href="{$imageLink}" data-caption="{$caption}" data-fancybox>
22-
<img src="{$imageLink}">
22+
<img src="{$thumbnailUrl}" width="…" height="…" alt="">
2323
</a>
2424
```
2525

2626
If you want to display several images in a group, you can group them using the `data-fancybox` attribute. Images with the same group name are then displayed together:
2727

2828
```smarty
2929
<a href="{$imageLink}" data-caption="{$caption}" data-fancybox="fooBar">
30-
<img src="{$imageLink}">
30+
<img src="{$thumbnailUrl}" width="…" height="…" alt="">
3131
</a>
3232
```
3333

@@ -73,7 +73,7 @@ final class FooBBCode extends AbstractBBCode
7373

7474
```smarty title="shared_bbcode_foo.tpl"
7575
<a href="{$imageLink}" data-caption="{$caption}" data-fancybox="message-{$activeMessageObjectType}-{$activeMessageObjectID}">
76-
<img src="{$imageLink}">
76+
<img src="{$thumbnailUrl}" width="…" height="…" alt="">
7777
</a>
7878
```
7979

docs/migration/wsc61/templates.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,22 @@
22

33
## Image Viewer
44

5-
The previous image viewer `WCF.ImageViewer` has been open by the HTML class `.jsImageViewer`.
5+
The previous image viewer `WCF.ImageViewer` used the CSS class `.jsImageViewer` to open the image viewer.
66
From now on this is done via the attribute `data-fancybox`, which opens the new [Image Viewer](../../javascript/components_image_viewer.md).
7-
Which also now supports grouping, `data-fancybox="foo"`.
7+
Grouping is supported through the attribute `data-fancybox="foo"`.
88

99
#### Previous Code Example
1010

1111
```smarty
1212
<a href="{$link}" class="jsImageViewer" title="{$title}">
13-
<img src="{$link}">
13+
<img src="{$thumbnailUrl}" width="…" height="…" alt="">
1414
</a>
1515
```
1616

1717
#### New Code Example
1818

1919
```smarty
2020
<a href="{$link}" data-caption="{$title}" data-fancybox>
21-
<img src="{$link}">
21+
<img src="{$thumbnailUrl}" width="…" height="…" alt="">
2222
</a>
2323
```

0 commit comments

Comments
 (0)