Skip to content

Commit 9e68502

Browse files
committed
Fix outdated usage of icons
Closes #407
1 parent 50c91a1 commit 9e68502

File tree

33 files changed

+52
-52
lines changed

33 files changed

+52
-52
lines changed

docs/php/api/form_builder/form_fields.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ Form fields of this class have `rating` as their default id, `wcf.form.field.rat
158158
For this field, the minimum and maximum refer to the minimum and maximum rating an object can get.
159159
When the field is shown, there will be `maximum() - minimum() + 1` icons be shown with additional CSS classes that can be set and gotten via `defaultCssClasses(array $cssClasses)` and `getDefaultCssClasses()`.
160160
If a rating values is set, the first `getValue()` icons will instead use the classes that can be set and gotten via `activeCssClasses(array $cssClasses)` and `getActiveCssClasses()`.
161-
By default, the only default class is `fa-star-o` and the active classes are `fa-star` and `orange`.
161+
By default, the only default class is `star-o` and the active classes are `star` and `orange`.
162162

163163

164164
### `SelectFormField`

docs/tutorial/series/part_3.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ For the `ILookupPageHandler` interface, we need to implement three methods:
186186
Here, we use `PersonRuntimeCache::getObject()` again and check if the return value is `null`, which is the case for non-existing people.
187187
1. `lookup($searchString)` is used when setting up an internal link and when searching for the linked person.
188188
This method simply searches the first and last name of the people and returns an array with the person data.
189-
While the `link`, the `objectID`, and the `title` element are self-explanatory, the `image` element can either contain an HTML `<img>` tag, which is displayed next to the search result (WoltLab Suite uses an image tag for users showing their avatar, for example), or a FontAwesome icon class (starting with `fa-`).
189+
While the `link`, the `objectID`, and the `title` element are self-explanatory, the `image` element can either contain an HTML `<img>` tag, which is displayed next to the search result (WoltLab Suite uses an image tag for users showing their avatar, for example), or a FontAwesome icon class.
190190

191191
Additionally, the class also implements [IOnlineLocationPageHandler](https://github.com/WoltLab/WCF/blob/master/wcfsetup/install/files/lib/system/page/handler/IOnlineLocationPageHandler.class.php) which is used to determine the online location of users.
192192
To ensure upwards-compatibility if the `IOnlineLocationPageHandler` interface changes, the [TOnlineLocationPageHandler](https://github.com/WoltLab/WCF/blob/master/wcfsetup/install/files/lib/system/page/handler/TOnlineLocationPageHandler.class.php) trait is used.

snippets/package/pip/bbcode.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
<htmlopen>div</htmlopen>
1616
<htmlclose>div</htmlclose>
1717
<isBlockElement>1</isBlockElement>
18-
<wysiwygicon>fa-bath</wysiwygicon>
18+
<wysiwygicon>bath</wysiwygicon>
1919
<buttonlabel>wcf.editor.button.example</buttonlabel>
2020
</bbcode>
2121
</import>
22-
</data>
22+
</data>

snippets/package/pip/userMenu.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<data xmlns="http://www.woltlab.com" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.woltlab.com http://www.woltlab.com/XSD/2019/userMenu.xsd">
33
<import>
44
<usermenuitem name="wcf.user.menu.foo">
5-
<iconclassname>fa-home</iconclassname>
5+
<iconclassname>home</iconclassname>
66
</usermenuitem>
77

88
<usermenuitem name="wcf.user.menu.foo.bar">
@@ -19,4 +19,4 @@
1919
<options>module_foo_bar</options>
2020
</usermenuitem>
2121
</import>
22-
</data>
22+
</data>

snippets/tutorial/tutorial-series/part-1/acpMenu.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<controller>wcf\acp\form\PersonAddForm</controller>
1414
<parent>wcf.acp.menu.link.person.list</parent>
1515
<permissions>admin.content.canManagePeople</permissions>
16-
<icon>fa-plus</icon>
16+
<icon>plus</icon>
1717
</acpmenuitem>
1818
</import>
1919
</data>

snippets/tutorial/tutorial-series/part-1/acptemplates/personAdd.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
<nav class="contentHeaderNavigation">
99
<ul>
10-
<li><a href="{link controller='PersonList'}{/link}" class="button"><span class="icon icon16 fa-list"></span> <span>{lang}wcf.acp.menu.link.person.list{/lang}</span></a></li>
10+
<li><a href="{link controller='PersonList'}{/link}" class="button">{icon name='list'} <span>{lang}wcf.acp.menu.link.person.list{/lang}</span></a></li>
1111

1212
{event name='contentHeaderNavigation'}
1313
</ul>

snippets/tutorial/tutorial-series/part-1/acptemplates/personList.tpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
<nav class="contentHeaderNavigation">
99
<ul>
10-
<li><a href="{link controller='PersonAdd'}{/link}" class="button"><span class="icon icon16 fa-plus"></span> <span>{lang}wcf.acp.menu.link.person.add{/lang}</span></a></li>
10+
<li><a href="{link controller='PersonAdd'}{/link}" class="button">{icon name='plus'} <span>{lang}wcf.acp.menu.link.person.add{/lang}</span></a></li>
1111

1212
{event name='contentHeaderNavigation'}
1313
</ul>
@@ -37,7 +37,7 @@
3737
{foreach from=$objects item=person}
3838
<tr class="jsObjectActionObject" data-object-id="{@$person->getObjectID()}">
3939
<td class="columnIcon">
40-
<a href="{link controller='PersonEdit' object=$person}{/link}" title="{lang}wcf.global.button.edit{/lang}" class="jsTooltip"><span class="icon icon16 fa-pencil"></span></a>
40+
<a href="{link controller='PersonEdit' object=$person}{/link}" title="{lang}wcf.global.button.edit{/lang}" class="jsTooltip">{icon name='pencil'}</a>
4141
{objectAction action="delete" objectTitle=$person->getTitle()}
4242

4343
{event name='rowButtons'}
@@ -62,7 +62,7 @@
6262

6363
<nav class="contentFooterNavigation">
6464
<ul>
65-
<li><a href="{link controller='PersonAdd'}{/link}" class="button"><span class="icon icon16 fa-plus"></span> <span>{lang}wcf.acp.menu.link.person.add{/lang}</span></a></li>
65+
<li><a href="{link controller='PersonAdd'}{/link}" class="button">{icon name='plus'} <span>{lang}wcf.acp.menu.link.person.add{/lang}</span></a></li>
6666

6767
{event name='contentFooterNavigation'}
6868
</ul>

snippets/tutorial/tutorial-series/part-1/templates/personList.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
{foreach from=$objects item=person}
5656
<li>
5757
<div class="box48">
58-
<span class="icon icon48 fa-user"></span>
58+
{icon name='user' size=48}
5959

6060
<div class="details personInformation">
6161
<div class="containerHeadline">

snippets/tutorial/tutorial-series/part-3/acpMenu.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<controller>wcf\acp\form\PersonAddForm</controller>
1414
<parent>wcf.acp.menu.link.person.list</parent>
1515
<permissions>admin.content.canManagePeople</permissions>
16-
<icon>fa-plus</icon>
16+
<icon>plus</icon>
1717
</acpmenuitem>
1818
</import>
1919
</data>

snippets/tutorial/tutorial-series/part-3/acptemplates/personAdd.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
<nav class="contentHeaderNavigation">
99
<ul>
10-
<li><a href="{link controller='PersonList'}{/link}" class="button"><span class="icon icon16 fa-list"></span> <span>{lang}wcf.acp.menu.link.person.list{/lang}</span></a></li>
10+
<li><a href="{link controller='PersonList'}{/link}" class="button">{icon name='list'} <span>{lang}wcf.acp.menu.link.person.list{/lang}</span></a></li>
1111

1212
{event name='contentHeaderNavigation'}
1313
</ul>

0 commit comments

Comments
 (0)