Skip to content

Commit 6c04862

Browse files
committed
disable uv face check
incorrect loop look up - finding degenerate faces in vanilla meshes even with epsilon set to 1e-17
1 parent 1e32657 commit 6c04862

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

i_scene_cp77_gltf/exporters/glb_export.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ def find_3d_degenerates(tempshit, eps=1e-10):
292292

293293
return np.flatnonzero(hits > 0)
294294

295-
def check_uv_degenerates(tempshit, uv_eps=1e-12):
295+
def check_uv_degenerates(tempshit, uv_eps=1e-17):
296296
"""
297297
Check for UV degenerate triangles using vectorized operations.
298298
@@ -528,20 +528,21 @@ def validate_mesh(ob, tempshit, eps=1e-10, uv_eps=1e-12):
528528

529529
bad_uv_faces = np.array([], dtype=np.int32)
530530
if not missing_uv:
531-
bad_uv_faces = check_uv_degenerates(tempshit, uv_eps)
532-
if len(bad_uv_faces) > 0:
533-
issues.append(ValidationIssue(
534-
'degenerate_uv',
535-
f"{len(bad_uv_faces)} UV degenerate faces detected in '{ob.name}'. "
536-
f"Fix UV mapping to ensure proper texture coordinates.",
537-
"https://tinyurl.com/uv-degenerate"
538-
))
531+
pass
532+
# bad_uv_faces = check_uv_degenerates(tempshit, uv_eps)
533+
# if len(bad_uv_faces) > 0:
534+
# issues.append(ValidationIssue(
535+
# 'degenerate_uv',
536+
# f"{len(bad_uv_faces)} UV degenerate faces detected in '{ob.name}'. "
537+
# f"Fix UV mapping to ensure proper texture coordinates.",
538+
# "https://tinyurl.com/uv-degenerate"
539+
# ))
539540

540541
return {
541542
'valid': len(issues) == 0,
542543
'issues': issues,
543544
'bad_3d_faces': bad_3d_faces,
544-
'bad_uv_faces': bad_uv_faces,
545+
#'bad_uv_faces': bad_uv_faces,
545546
'vertex_stats': vertex_stats
546547
}
547548

@@ -641,7 +642,7 @@ def cp77_meshValidation(
641642
meshes: list[bpy.types.Object],
642643
*,
643644
eps: float = 1e-10,
644-
uv_eps: float = 1e-12,
645+
uv_eps: float = 1e-17,
645646
is_skinned: bool = False,
646647
try_fix: bool = True,
647648
) -> dict:

0 commit comments

Comments
 (0)