fix: static stack returning invalid value on pop_value

WolverinDEV · WolverinDEV · commit 1a3a8dc32880 · 2024-12-07T19:17:55.000+09:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -3,7 +3,7 @@ resolver = "2"
 members = ["bmatcher", "bmatcher-core", "bmatcher-proc", "example"]
 
 [workspace.package]
-version = "0.2.0"
+version = "0.2.1"
 authors = ["Markus Hadenfeldt <mhadenfeldt@did.science>"]
 edition = "2021"
 description = "bmatcher is a flexible and efficient binary pattern matching library designed to help you search and match binary data."
diff --git a/bmatcher-core/src/stack.rs b/bmatcher-core/src/stack.rs
@@ -55,8 +55,8 @@ impl<const N: usize, T: Default + Copy> Stack<T> for StaticStack<N, T> {
 
     fn pop_value(&mut self) -> Option<T> {
         if self.length > 0 {
-            let value = self.stack[self.length];
             self.length -= 1;
+            let value = self.stack[self.length];
             Some(value)
         } else {
             None
