Replies: 4 comments 1 reply
-
|
I had this thought too when @nrjdalal suggested adding these animations. The reason I still went with it is the fact this allows shadcn or other library authors to focus on components instead of tinkering with animations and "polluting" their CSS. If they still need a custom animation, I'd be happy to add it to To make it clear this is not just a 1:1 port of |
Beta Was this translation helpful? Give feedback.
-
|
@Khalilou88 try creating any project, and add Even if @Wombosvideo add 20-30 other classes, it won't matter. Great statement @Wombosvideo, and due to Tailwind CSS "tree-shaking" away all unused utilities, people who don't use these extra animations don't have to worry about extra bundle size. |
Beta Was this translation helpful? Give feedback.
-
|
also @Wombosvideo you should add that note in docs I guess, so peeps don't feel it's bloated or have bundlephobia |
Beta Was this translation helpful? Give feedback.
-
|
@nrjdalal Thanks, will do. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi,
Thanks for your library and the work you've put into it. I have a question about why you included ShadCN animations in the library instead of keeping it Tailwind CSS-specific.
Wouldn't it be better to separate these animations into a different file or library? This could help keep the core library more generic and flexible.
Thanks
Beta Was this translation helpful? Give feedback.
All reactions