Merge pull request #1665 from WordPress-Coding-Standards/feature/globalvarsoverride-implement-is-foreach-as

GlobalVariablesOverride: implement the Sniff::is_foreach_as() method

Author: GaryJones

WordPress/Sniffs/WP/GlobalVariablesOverrideSniff.php

@@ -321,17 +321,8 @@ protected function process_global_statement( $stackPtr, $in_function_scope ) {
 			}
 
 			// Check if this is a variable assignment within a `foreach()` declaration.
-			if ( isset( $this->tokens[ $ptr ]['nested_parenthesis'] ) ) {
-				$nested_parenthesis = $this->tokens[ $ptr ]['nested_parenthesis'];
-				$close_parenthesis  = end( $nested_parenthesis );
-				if ( isset( $this->tokens[ $close_parenthesis ]['parenthesis_owner'] )
-					&& \T_FOREACH === $this->tokens[ $this->tokens[ $close_parenthesis ]['parenthesis_owner'] ]['code']
-					&& ( false !== $previous
-						&& ( \T_DOUBLE_ARROW === $this->tokens[ $previous ]['code']
-						|| \T_AS === $this->tokens[ $previous ]['code'] ) )
-				) {
-					$this->maybe_add_error( $ptr );
-				}
+			if ( $this->is_foreach_as( $ptr ) === true ) {
+				$this->maybe_add_error( $ptr );
 			}
 		}
 	}