Update NonceVerificationUnitTest.1.inc now that there are dedicated tests for the is_in_function_call() method

rodrigoprimo · rodrigoprimo · commit 3fc573626a07 · 2025-11-11T09:40:26.000-03:00
- Remove the @Covers is_in_function_call() tag - Remove code comment. The tests are still relevant for the sniff, but are not anymore specifically to test is_in_function_call().
diff --git a/WordPress/Tests/Security/NonceVerificationUnitTest.1.inc b/WordPress/Tests/Security/NonceVerificationUnitTest.1.inc
@@ -291,7 +291,7 @@ function function_containing_nested_closure() {
 	};
 }
 
-// Tests specifically for the ContextHelper::is_in_function_call().
+
 function disallow_custom_unslash_before_noncecheck_via_method() {
 	$var = MyClass::stripslashes_from_strings_only( $_POST['foo'] ); // Bad.
 	wp_verify_nonce( $var );
diff --git a/WordPress/Tests/Security/NonceVerificationUnitTest.php b/WordPress/Tests/Security/NonceVerificationUnitTest.php
@@ -18,7 +18,6 @@
  * @since 0.13.0 Class name changed: this class is now namespaced.
  * @since 1.0.0  This sniff has been moved from the `CSRF` category to the `Security` category.
  *
- * @covers \WordPressCS\WordPress\Helpers\ContextHelper::is_in_function_call
  * @covers \WordPressCS\WordPress\Helpers\ContextHelper::is_in_type_test
  * @covers \WordPressCS\WordPress\Helpers\ContextHelper::is_in_isset_or_empty
  * @covers \WordPressCS\WordPress\Helpers\ContextHelper::is_in_array_comparison

Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ function function_containing_nested_closure() {`
`291`	`291`	`};`
`292`	`292`	`}`
`293`	`293`
`294`		`-// Tests specifically for the ContextHelper::is_in_function_call().`
	`294`	`+`
`295`	`295`	`function disallow_custom_unslash_before_noncecheck_via_method() {`
`296`	`296`	`$var = MyClass::stripslashes_from_strings_only( $_POST['foo'] ); // Bad.`
`297`	`297`	`wp_verify_nonce( $var );`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`* @since 0.13.0 Class name changed: this class is now namespaced.`
`19`	`19`	* @since 1.0.0 This sniff has been moved from the `CSRF` category to the `Security` category.
`20`	`20`	`*`
`21`		`- * @covers \WordPressCS\WordPress\Helpers\ContextHelper::is_in_function_call`
`22`	`21`	`* @covers \WordPressCS\WordPress\Helpers\ContextHelper::is_in_type_test`
`23`	`22`	`* @covers \WordPressCS\WordPress\Helpers\ContextHelper::is_in_isset_or_empty`
`24`	`23`	`* @covers \WordPressCS\WordPress\Helpers\ContextHelper::is_in_array_comparison`