Tests: use standardized fixture methods

As support for PHPUnit < 8.0 will now be dropped, we no longer need to use the `@before`/`@after`[Class] annotations for fixture methods and can revert back to using the standard PHPUnit `setUp|tearDown[BeforeClass]()` fixture methods (with a `void` return type).

Author: rodrigoprimo

WordPress/Tests/DB/RestrictedClassesUnitTest.php

@@ -32,11 +32,10 @@ final class RestrictedClassesUnitTest extends AbstractSniffUnitTest {
 	 * Note: as that class extends the abstract FunctionRestrictions class, that's
 	 * where we are passing the parameters to.
 	 *
-	 * @before
-	 *
 	 * @return void
 	 */
-	protected function enhanceGroups() {
+	protected function setUp(): void {
+		parent::setUp();
 		AbstractFunctionRestrictionsSniff::$unittest_groups = array(
 			'test' => array(
 				'type'    => 'error',
@@ -52,11 +51,9 @@ protected function enhanceGroups() {
 	/**
 	 * Reset the $groups property.
 	 *
-	 * @after
-	 *
 	 * @return void
 	 */
-	protected function resetGroups() {
+	protected function tearDown(): void {
 		AbstractFunctionRestrictionsSniff::$unittest_groups = array();
 		parent::tearDown();
 	}

WordPress/Tests/DB/RestrictedFunctionsUnitTest.php

@@ -27,13 +27,10 @@ final class RestrictedFunctionsUnitTest extends AbstractSniffUnitTest {
 	 * Add a number of extra restricted functions to unit test the abstract
 	 * AbstractFunctionRestrictionsSniff class.
 	 *
-	 * @before
-	 *
 	 * @return void
 	 */
-	protected function enhanceGroups() {
+	protected function setUp(): void {
 		parent::setUp();
-
 		AbstractFunctionRestrictionsSniff::$unittest_groups = array(
 			'test-empty-functions-array' => array(
 				'type'      => 'error',
@@ -52,11 +49,9 @@ protected function enhanceGroups() {
 	/**
 	 * Reset the $groups property.
 	 *
-	 * @after
-	 *
 	 * @return void
 	 */
-	protected function resetGroups() {
+	protected function tearDown(): void {
 		AbstractFunctionRestrictionsSniff::$unittest_groups = array();
 		parent::tearDown();
 	}