NamingConventions/PrefixAllGlobals: update min prefix length from 3 to 4 chars (#2479)

Author: davidperezgar

WordPress/Docs/NamingConventions/PrefixAllGlobalsStandard.xml

@@ -101,7 +101,7 @@ function <em>wp_save_post()</em> {}
     </code_comparison>
     <standard>
     <![CDATA[
-    Prefixes must have a minimum length of three character to be considered valid, as many plugins and themes share the same initials.
+    Prefixes must have a minimum length of four character to be considered valid, as many plugins and themes share the same initials.
     ]]>
     </standard>
     <code_comparison>

WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php

@@ -59,12 +59,14 @@ final class PrefixAllGlobalsSniff extends AbstractFunctionParameterSniff {
 	 * Minimal number of characters the prefix needs in order to be valid.
 	 *
 	 * @since 2.2.0
+	 * @since 3.2.0 The minimum number of characters was raised from 3 to 4.
 	 *
 	 * @link https://github.com/WordPress/WordPress-Coding-Standards/issues/1733 Issue 1733.
+	 * @link https://github.com/WordPress/WordPress-Coding-Standards/issues/2467 Issue 2467.
 	 *
 	 * @var int
 	 */
-	const MIN_PREFIX_LENGTH = 3;
+	const MIN_PREFIX_LENGTH = 4;
 
 	/**
 	 * Target prefixes.

WordPress/Tests/NamingConventions/PrefixAllGlobalsUnitTest.1.inc

@@ -6,8 +6,8 @@
 // phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[] wp
 function wp_do_something() {}
 
-// phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[] ^%&
-function ^%&_do_something() {}
+// phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[] ^%&%
+function ^%&%_do_something() {}
 
 // Now let's set the real prefixes we want to test for.
 // phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[] acronym,tgmpa
@@ -511,13 +511,13 @@ function aa_do_something(){}
 
 // The following line mimics an empty prefix value.
 // phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[] ,
-function aaa_do_something(){}
+function aaaa_do_something(){}
 
 // phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[] 😊
 function 😊_do_something(){}
 
-// phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[] 😊😊
-function 😊😊_do_something(){}
+// phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[] 😊😊😊
+function 😊😊😊_do_something(){}
 
 // Reset to the standard test prefixes.
 // phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[] acronym,tgmpa