GlobalVariablesOverride: move parse error test to separate file

... as it would cause a fixer conflict with the new rules.

As the fixer conflict is directly related to the parse error, I'm not concerned about it and I don't believe a fix is needed for the sniff.

Excluding this particular parse error file from the fixer conflict check should be an acceptable solution.

Author: jrfnl

.github/workflows/basic-qa.yml

@@ -152,7 +152,7 @@ jobs:
         continue-on-error: true
         run: |
           set +e
-          $(pwd)/vendor/bin/phpcbf -pq ./WordPress/Tests/ --standard=WordPress --extensions=inc --exclude=Generic.PHP.Syntax --report=summary --ignore=/WordPress/Tests/NamingConventions/ValidVariableNameUnitTest.inc
+          $(pwd)/vendor/bin/phpcbf -pq ./WordPress/Tests/ --standard=WordPress --extensions=inc --exclude=Generic.PHP.Syntax --report=summary --ignore=/WordPress/Tests/NamingConventions/ValidVariableNameUnitTest.inc,/WordPress/Tests/WP/GlobalVariablesOverrideUnitTest.7.inc
           exitcode="$?"
           echo "EXITCODE=$exitcode" >> $GITHUB_OUTPUT
           exit "$exitcode"

WordPress/Tests/WP/GlobalVariablesOverrideUnitTest.1.inc

@@ -183,20 +183,20 @@ function global_vars() {
 	return $closure( $pagenow ); // OK, not an assignment.
 }
 
-// Verify skipping over rest of the function when live coding/parse error in nested scope structure.
-function global_vars() {
-	global $pagenow;
 
-	$closure = function ( $pagenow ) {
-		global $feeds;
 
-		$nested_closure_with_parse_error = function ( $feeds )
 
-		$feeds = 'something'; // Bad, but ignored because of the parse error in the closure.
-	};
 
-	$pagenow = 'something'; // Bad, should be picked up. Tests that skipping on parse error doesn't skip too far.
-}
+
+
+
+
+
+
+
+
+
+
 
 $GLOBALS[] = 'something';
 $GLOBALS[103] = 'something';
@@ -314,4 +314,3 @@ list(
 // Live coding/parse error.
 // This has to be the last test in the file!
 list( $tab, $tabs
-

WordPress/Tests/WP/GlobalVariablesOverrideUnitTest.7.inc

@@ -0,0 +1,20 @@
+<?php
+
+/*
+ * Separate test file to isolate the parse error test.
+ */
+
+// Verify skipping over rest of the function when live coding/parse error in nested scope structure.
+function global_vars() {
+	global $pagenow;
+
+	$closure = function ( $pagenow ) {
+		global $feeds;
+
+		$nested_closure_with_parse_error = function ( $feeds )
+
+		$feeds = 'something'; // Bad, but ignored because of the parse error in the closure.
+	};
+
+	$pagenow = 'something'; // Bad, should be picked up. Tests that skipping on parse error doesn't skip too far.
+}

WordPress/Tests/WP/GlobalVariablesOverrideUnitTest.php

@@ -59,7 +59,6 @@ public function getErrorList( $testFile = '' ) {
 					143 => 1,
 					146 => 1,
 					181 => 1,
-					198 => 1,
 					212 => 4,
 					230 => 2,
 					231 => 2,
@@ -91,6 +90,11 @@ public function getErrorList( $testFile = '' ) {
 					29 => 1,
 				);
 
+			case 'GlobalVariablesOverrideUnitTest.7.inc':
+				return array(
+					19 => 1,
+				);
+
 			default:
 				return array();
 		}