Deletes duplicate code and removes incorrect second parameter strlen

Author: NielsdeBlaauw

WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php

@@ -925,15 +925,12 @@ private function validate_prefixes() {
 				continue;
 			}
 
-			if ( function_exists( 'iconv_strlen' ) && iconv_strlen( $prefix, $this->phpcsFile->config->encoding ) < self::MIN_PREFIX_LENGTH ) {
-				$this->phpcsFile->addError(
-					'The "%s" prefix is too short. Short prefixes are not unique enough and may cause name collisions with other code.',
-					0,
-					'ShortPrefixPassed',
-					array( $prefix )
-				);
-				continue;
-			} elseif ( ! function_exists( 'iconv_strlen' ) && strlen( $prefix, $this->phpcsFile->config->encoding ) < self::MIN_PREFIX_LENGTH ) {
+			$prefix_length = strlen( $prefix );
+			if ( function_exists( 'iconv_strlen' ) ) {
+				$prefix_length = iconv_strlen( $prefix, $this->phpcsFile->config->encoding );
+			}
+
+			if ( $prefix_length < self::MIN_PREFIX_LENGTH ) {
 				$this->phpcsFile->addError(
 					'The "%s" prefix is too short. Short prefixes are not unique enough and may cause name collisions with other code.',
 					0,