Merge pull request #1666 from WordPress-Coding-Standards/feature/array-keys-strtolower-simpler

Clean up: use array_change_key_case()

Author: jrfnl

WordPress/Sniffs/WP/DeprecatedClassesSniff.php

@@ -58,13 +58,11 @@ class DeprecatedClassesSniff extends AbstractClassRestrictionsSniff {
 	 */
 	public function getGroups() {
 		// Make sure all array keys are lowercase.
-		$keys                     = array_keys( $this->deprecated_classes );
-		$keys                     = array_map( 'strtolower', $keys );
-		$this->deprecated_classes = array_combine( $keys, $this->deprecated_classes );
+		$this->deprecated_classes = array_change_key_case( $this->deprecated_classes, CASE_LOWER );
 
 		return array(
 			'deprecated_classes' => array(
-				'classes' => $keys,
+				'classes' => array_keys( $this->deprecated_classes ),
 			),
 		);
 	}

WordPress/Sniffs/WP/DeprecatedFunctionsSniff.php

@@ -1339,13 +1339,11 @@ class DeprecatedFunctionsSniff extends AbstractFunctionRestrictionsSniff {
 	 */
 	public function getGroups() {
 		// Make sure all array keys are lowercase.
-		$keys                       = array_keys( $this->deprecated_functions );
-		$keys                       = array_map( 'strtolower', $keys );
-		$this->deprecated_functions = array_combine( $keys, $this->deprecated_functions );
+		$this->deprecated_functions = array_change_key_case( $this->deprecated_functions, CASE_LOWER );
 
 		return array(
 			'deprecated_functions' => array(
-				'functions' => $keys,
+				'functions' => array_keys( $this->deprecated_functions ),
 			),
 		);
 	}