Arrays/ArrayDeclarationSpacing::process_single_line_array(): lower nesting level

As the checks for whitespace around the array opener/closer have now been removed, the code in the `process_single_line_array()` method no longer needs to be nested in condition upon condition.

This commit applies the typical "bow out early" pattern to the code in the method.

:point_right: This change will be easier to review while ignoring whitespace changes.

Author: jrfnl

WordPress/Sniffs/Arrays/ArrayDeclarationSpacingSniff.php

@@ -117,44 +117,46 @@ public function process_token( $stackPtr ) {
 	 */
 	protected function process_single_line_array( $stackPtr, $opener, $closer ) {
 		$array_items = PassedParameters::getParameters( $this->phpcsFile, $stackPtr );
-
 		if ( ( false === $this->allow_single_item_single_line_associative_arrays
-				&& ! empty( $array_items ) )
+				&& empty( $array_items ) )
 			|| ( true === $this->allow_single_item_single_line_associative_arrays
-				&& \count( $array_items ) > 1 )
+				&& \count( $array_items ) === 1 )
 		) {
-			/*
-			 * Make sure the double arrow is for *this* array, not for a nested one.
-			 */
-			$array_has_keys = false; // Reset before doing more detailed check.
-			foreach ( $array_items as $item ) {
-				if ( Arrays::getDoubleArrowPtr( $this->phpcsFile, $item['start'], $item['end'] ) !== false ) {
-					$array_has_keys = true;
-					break;
-				}
-			}
-
-			if ( true === $array_has_keys ) {
-				$error = 'When an array uses associative keys, each value should start on %s.';
-				if ( true === $this->allow_single_item_single_line_associative_arrays ) {
-					$error = 'When a multi-item array uses associative keys, each value should start on %s.';
-				}
+			return;
+		}
 
-				/*
-				 * Just add a new line before the array closer.
-				 * The multi-line array fixer will then fix the individual array items in the next fixer loop.
-				 */
-				SpacesFixer::checkAndFix(
-					$this->phpcsFile,
-					$closer,
-					$this->phpcsFile->findPrevious( \T_WHITESPACE, ( $closer - 1 ), null, true ),
-					'newline',
-					$error,
-					'AssociativeArrayFound',
-					'error'
-				);
+		/*
+		 * Make sure the double arrow is for *this* array, not for a nested one.
+		 */
+		$array_has_keys = false;
+		foreach ( $array_items as $item ) {
+			if ( Arrays::getDoubleArrowPtr( $this->phpcsFile, $item['start'], $item['end'] ) !== false ) {
+				$array_has_keys = true;
+				break;
 			}
 		}
+
+		if ( false === $array_has_keys ) {
+			return;
+		}
+		$error = 'When an array uses associative keys, each value should start on %s.';
+		if ( true === $this->allow_single_item_single_line_associative_arrays ) {
+			$error = 'When a multi-item array uses associative keys, each value should start on %s.';
+		}
+
+		/*
+		 * Just add a new line before the array closer.
+		 * The multi-line array fixer will then fix the individual array items in the next fixer loop.
+		 */
+		SpacesFixer::checkAndFix(
+			$this->phpcsFile,
+			$closer,
+			$this->phpcsFile->findPrevious( \T_WHITESPACE, ( $closer - 1 ), null, true ),
+			'newline',
+			$error,
+			'AssociativeArrayFound',
+			'error'
+		);
 	}
 
 	/**