Skip to content

Commit 8a455f0

Browse files
committed
GH Actions/fixer conflict check: remove temporary exclusion
Upstream PR squizlabs/PHP_CodeSniffer 3833 has now been merged, so the exclusion introduced in 2243 can be removed and the fixer conflict check passes again without issues. Fixes 2274
1 parent 44f3abb commit 8a455f0

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

.github/workflows/basic-qa.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,15 +151,13 @@ jobs:
151151
# Test for fixer conflicts by running the auto-fixers of the complete WPCS over the test case files.
152152
# This is not an exhaustive test, but should give an early indication for typical fixer conflicts.
153153
# If only fixable errors are found, the exit code will be 1, which can be interpreted as success.
154-
#
155-
# Note: the ValidVariableNameUnitTest.inc file is temporarily ignored until upstream PHPCS PR 3833 has been merged.
156154
- name: Test for fixer conflicts (fixes expected)
157155
if: ${{ matrix.phpcs_version == 'dev-master' }}
158156
id: phpcbf
159157
continue-on-error: true
160158
run: |
161159
set +e
162-
$(pwd)/vendor/bin/phpcbf -pq ./WordPress/Tests/ --standard=WordPress --extensions=inc --exclude=Generic.PHP.Syntax --report=summary --ignore=/WordPress/Tests/NamingConventions/ValidVariableNameUnitTest.inc,/WordPress/Tests/WP/GlobalVariablesOverrideUnitTest.7.inc
160+
$(pwd)/vendor/bin/phpcbf -pq ./WordPress/Tests/ --standard=WordPress --extensions=inc --exclude=Generic.PHP.Syntax --report=summary --ignore=/WordPress/Tests/WP/GlobalVariablesOverrideUnitTest.7.inc
163161
exitcode="$?"
164162
echo "EXITCODE=$exitcode" >> $GITHUB_OUTPUT
165163
exit "$exitcode"

0 commit comments

Comments
 (0)