Adds more testcases. Option value is no longer case sensitive

Author: NielsdeBlaauw

WordPress/Sniffs/PHP/IniSetSniff.php

@@ -60,7 +60,7 @@ class IniSetSniff extends AbstractFunctionParameterSniff {
 		'highlight.keyword'        => array(),
 		'highlight.string'         => array(),
 		'short_open_tag'           => array(
-			'valid_values' => array( 'true', '1', 'On' ),
+			'valid_values' => array( 'true', '1', 'on' ),
 		),
 	);
 
@@ -115,7 +115,7 @@ class IniSetSniff extends AbstractFunctionParameterSniff {
 			'message' => 'Use `wp_raise_memory_limit()` or hook into the filters in that function.',
 		),
 		'short_open_tag' => array(
-			'invalid_values' => array( 'false', '0', 'Off' ),
+			'invalid_values' => array( 'false', '0', 'off' ),
 			'message'        => 'Turning off short_open_tag is prohibited as it can break other plugins.',
 		),
 	);
@@ -140,14 +140,14 @@ public function process_parameters( $stackPtr, $group_name, $matched_content, $p
 		$option_value = $this->strip_quotes( $parameters[2]['raw'] );
 		if ( isset( $this->whitelisted_options[ $option_name ] ) ) {
 			$whitelisted_option = $this->whitelisted_options[ $option_name ];
-			if ( ! isset( $whitelisted_option['valid_values'] ) || in_array( $option_value, $whitelisted_option['valid_values'], true ) ) {
+			if ( ! isset( $whitelisted_option['valid_values'] ) || in_array( strtolower( $option_value ), $whitelisted_option['valid_values'], true ) ) {
 				return;
 			}
 		}
 
 		if ( isset( $this->blacklisted_options[ $option_name ] ) ) {
 			$blacklisted_option = $this->blacklisted_options[ $option_name ];
-			if ( ! isset( $blacklisted_option['invalid_values'] ) || in_array( $option_value, $blacklisted_option['invalid_values'], true ) ) {
+			if ( ! isset( $blacklisted_option['invalid_values'] ) || in_array( strtolower( $option_value ), $blacklisted_option['invalid_values'], true ) ) {
 				$this->phpcsFile->addError(
 					'%s(%s, %s) found. %s',
 					$stackPtr,

WordPress/Tests/PHP/IniSetUnitTest.inc

@@ -1,6 +1,7 @@
 <?php
 
 ini_set('auto_detect_line_endings', true); // Ok.
+ini_set( 'auto_detect_line_endings',true) ; // Ok.
 ini_set('highlight.bg', '#FFFFFF'); // Ok.
 ini_set('highlight.comment', '#FFFFFF'); // Ok.
 ini_set('highlight.default', '#FFFFFF'); // Ok.
@@ -10,8 +11,10 @@ ini_set('highlight.string', '#FFFFFF'); // Ok.
 ini_set('short_open_tag', true); // Ok.
 ini_set('short_open_tag', 1); // Ok.
 ini_set('short_open_tag', 'On'); // Ok.
+ini_set('short_open_tag', 'on'); // Ok.
 
 ini_set('bcmath.scale', 0); // Error.
+ini_set( 'bcmath.scale' ,0 ); // Error.
 ini_set('display_errors', 0); // Error.
 ini_set('error_reporting', 0); // Error.
 ini_set('filter.default', 'full_special_chars'); // Error.
@@ -25,10 +28,13 @@ ini_set('log_errors', true); // Error.
 ini_set('max_execution_time', 60); // Error.
 ini_set('memory_limit', -1); // Error.
 ini_set('short_open_tag', false); // Error.
+ini_set('short_open_tag', FALSE); // Error.
+ini_set('short_open_tag', FaLsE); // Error.
 ini_set('short_open_tag', 0); // Error.
 ini_set('short_open_tag', 'Off'); // Error.
 
 ini_set('report_memleaks', true); // Warning.
+ini_set('report_memleaks',true); // Warning.
 ini_set('short_open_tag', 1230); // Warning.
 ini_set($test, 1230); // Warning.
 

WordPress/Tests/PHP/IniSetUnitTest.php

@@ -27,8 +27,6 @@ class IniSetUnitTest extends AbstractSniffUnitTest {
 	 */
 	public function getErrorList() {
 		return array(
-			14 => 1,
-			15 => 1,
 			16 => 1,
 			17 => 1,
 			18 => 1,
@@ -43,7 +41,12 @@ public function getErrorList() {
 			27 => 1,
 			28 => 1,
 			29 => 1,
-			36 => 1,
+			30 => 1,
+			31 => 1,
+			32 => 1,
+			33 => 1,
+			34 => 1,
+			42 => 1,
 		);
 	}
 
@@ -54,10 +57,11 @@ public function getErrorList() {
 	 */
 	public function getWarningList() {
 		return array(
-			31 => 1,
-			32 => 1,
-			33 => 1,
+			36 => 1,
 			37 => 1,
+			38 => 1,
+			39 => 1,
+			43 => 1,
 		);
 	}