Merge pull request #2122 from WordPress/feature/qa-dont-allow-cs-warnings

CS: minor tweaks/don't allow warnings

Author: dingo-d

.github/workflows/ruleset-checks-sniffs.yml

@@ -68,13 +68,13 @@ jobs:
       # WordPress Coding Standards.
       # @link https://github.com/WordPress/WordPress-Coding-Standards
       # @link http://pear.php.net/package/PHP_CodeSniffer/
-      - name: Run PHPCS ignoring warnings
+      - name: Check the code style of the PHP files
         id: phpcs
-        run: vendor/bin/phpcs --runtime-set ignore_warnings_on_exit 1 --report-full --report-checkstyle=./phpcs-report.xml
+        run: vendor/bin/phpcs --report-full --report-checkstyle=./phpcs-report.xml
 
       - name: Show PHPCS results in PR
         if: ${{ always() && steps.phpcs.outcome == 'failure' }}
-        run: cs2pr ./phpcs-report.xml --graceful-warnings
+        run: cs2pr ./phpcs-report.xml
 
       # Validate the Ruleset XML files.
       # @link http://xmlsoft.org/xmllint.html

WordPress/AbstractFunctionParameterSniff.php

@@ -106,8 +106,5 @@ abstract public function process_parameters( $stackPtr, $group_name, $matched_co
 	 * @return int|void Integer stack pointer to skip forward or void to continue
 	 *                  normal file processing.
 	 */
-	public function process_no_parameters( $stackPtr, $group_name, $matched_content ) {
-		return;
-	}
-
+	public function process_no_parameters( $stackPtr, $group_name, $matched_content ) {}
 }

WordPress/Tests/WhiteSpace/ControlStructureSpacingUnitTest.php

@@ -72,15 +72,6 @@ public function getErrorList( $testFile = '' ) {
 					267 => 1,
 				);
 
-				/*
-				Uncomment when "$blank_line_check" parameter will be "true" by default.
-
-				$ret[29] += 1;
-				$ret[33]  = 1;
-				$ret[36]  = 1;
-				$ret[38]  = 1;
-				 */
-
 				return $ret;
 
 			case 'ControlStructureSpacingUnitTest.2.inc':