Commit c7d9a20
committed
WordPress-Extra: remove the
The `Generic.Functions.CallTimePassByReference` sniff was deprecated in PHPCS 3.13.0 and will be removed in PHPCS 4.0 (PHPCSStandards/PHP_CodeSniffer#921).
Removing this sniff from WordPress-Extra will be necessary anyway when preparing this repository for PHPCS 4.0, and I believe it is something that can be done now as call-time pass-by-reference was deprecated in PHP 5.3 (https://web.archive.org/web/20150920055013/http://us1.php.net/manual/en/migration53.deprecated.php) and removed in PHP 5.4 (https://web.archive.org/web/20140815142840/http://us2.php.net/manual/en/migration54.incompatible.php). PHP 5.4 was released in 2012, with the last security release in 2015. So it is unlikely users are still relying on it, and even if they are, there is a PHPCompatibility sniff to check for the use of call-time pass-by-reference: PHPCompatibility.Syntax.ForbiddenCallTimePassByReference (https://github.com/PHPCompatibility/PHPCompatibility/blob/9013cd039fe5740953f9fdeebd19d901b80e26f2/PHPCompatibility/Sniffs/Syntax/ForbiddenCallTimePassByReferenceSniff.php#L128).
This sniff was added to WordPress-Extra via #382 back in 2015.Generic.Functions.CallTimePassByReference sniff1 parent 20f3d5e commit c7d9a20
1 file changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | 18 | | |
20 | 19 | | |
21 | 20 | | |
| |||
0 commit comments