AbstractFunctionRestrictions: implement Sniff::is_class_object_call() and Sniff::is_token_namespaced()

Author: jrfnl

WordPress/AbstractFunctionRestrictionsSniff.php

@@ -213,7 +213,15 @@ public function process_token( $stackPtr ) {
 	public function is_targetted_token( $stackPtr ) {
 
 		// Exclude function definitions, class methods, and namespaced calls.
-		if ( \T_STRING === $this->tokens[ $stackPtr ]['code'] && isset( $this->tokens[ ( $stackPtr - 1 ) ] ) ) {
+		if ( \T_STRING === $this->tokens[ $stackPtr ]['code'] ) {
+			if ( $this->is_class_object_call( $stackPtr ) === true ) {
+				return false;
+			}
+
+			if ( $this->is_token_namespaced( $stackPtr ) === true ) {
+				return false;
+			}
+
 			$prev = $this->phpcsFile->findPrevious( Tokens::$emptyTokens, ( $stackPtr - 1 ), null, true );
 
 			if ( false !== $prev ) {
@@ -222,21 +230,11 @@ public function is_targetted_token( $stackPtr ) {
 					\T_FUNCTION        => \T_FUNCTION,
 					\T_CLASS           => \T_CLASS,
 					\T_AS              => \T_AS, // Use declaration alias.
-					\T_DOUBLE_COLON    => \T_DOUBLE_COLON,
-					\T_OBJECT_OPERATOR => \T_OBJECT_OPERATOR,
 				);
 
 				if ( isset( $skipped[ $this->tokens[ $prev ]['code'] ] ) ) {
 					return false;
 				}
-
-				// Skip namespaced functions, ie: \foo\bar() not \bar().
-				if ( \T_NS_SEPARATOR === $this->tokens[ $prev ]['code'] ) {
-					$pprev = $this->phpcsFile->findPrevious( Tokens::$emptyTokens, ( $prev - 1 ), null, true );
-					if ( false !== $pprev && \T_STRING === $this->tokens[ $pprev ]['code'] ) {
-						return false;
-					}
-				}
 			}
 
 			return true;

WordPress/Tests/PHP/DevelopmentFunctionsUnitTest.inc

@@ -32,3 +32,8 @@ phpinfo(); // Ok - within excluded group.
 // phpcs:set WordPress.PHP.DevelopmentFunctions exclude[]
 trigger_error(); // Error.
 phpinfo(); // Error.
+
+Wrapper_Class::var_dump(); // OK, not the native PHP function.
+$wrapper ->var_dump(); // OK, not the native PHP function.
+namespace\var_dump(); // OK as long as the file is namespaced.
+MyNamespace\var_dump(); // OK, namespaced function.