Merge pull request #1671 from WordPress-Coding-Standards/feature/sniff-is-assignment-defensive-coding

GaryJones · web-flow · commit cb8cd90795fc · 2019-03-31T10:47:30.000+01:00
Sniff::is_assignment(): minor defensive coding tweak
diff --git a/WordPress/Sniff.php b/WordPress/Sniff.php
@@ -1321,7 +1321,9 @@ protected function is_assignment( $stackPtr ) {
 		}
 
 		// Check if this is an array assignment, e.g., `$var['key'] = 'val';` .
-		if ( \T_OPEN_SQUARE_BRACKET === $this->tokens[ $next_non_empty ]['code'] ) {
+		if ( \T_OPEN_SQUARE_BRACKET === $this->tokens[ $next_non_empty ]['code']
+			&& isset( $this->tokens[ $next_non_empty ]['bracket_closer'] )
+		) {
 			return $this->is_assignment( $this->tokens[ $next_non_empty ]['bracket_closer'] );
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1321,7 +1321,9 @@ protected function is_assignment( $stackPtr ) {`
`1321`	`1321`	`}`
`1322`	`1322`
`1323`	`1323`	// Check if this is an array assignment, e.g., `$var['key'] = 'val';` .
`1324`		`- if ( \T_OPEN_SQUARE_BRACKET === $this->tokens[ $next_non_empty ]['code'] ) {`
	`1324`	`+ if ( \T_OPEN_SQUARE_BRACKET === $this->tokens[ $next_non_empty ]['code']`
	`1325`	`+ && isset( $this->tokens[ $next_non_empty ]['bracket_closer'] )`
	`1326`	`+ ) {`
`1325`	`1327`	`return $this->is_assignment( $this->tokens[ $next_non_empty ]['bracket_closer'] );`
`1326`	`1328`	`}`
`1327`	`1329`