Skip to content

Commit 6a263dc

Browse files
committed
Revert "TypeScript-ify common bin script"
This reverts commit 96dbb11.
1 parent 0eabc6b commit 6a263dc

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed
Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ const { readJSONFile } = require( '../lib/utils' );
1313
* Finds the name of the current plugin release branch based on the version in
1414
* the package.json file and the latest `trunk` branch in `git`.
1515
*
16-
* @param gitWorkingDirectoryPath Path to the project's working directory.
16+
* @param {string} gitWorkingDirectoryPath Path to the project's working directory.
1717
*
18-
* @return Name of the plugin release branch.
18+
* @return {string} Name of the plugin release branch.
1919
*/
20-
async function findPluginReleaseBranchName( gitWorkingDirectoryPath: string ) {
20+
async function findPluginReleaseBranchName( gitWorkingDirectoryPath ) {
2121
await SimpleGit( gitWorkingDirectoryPath )
2222
.fetch( 'origin', 'trunk' )
2323
.checkout( 'trunk' );
@@ -33,17 +33,17 @@ async function findPluginReleaseBranchName( gitWorkingDirectoryPath: string ) {
3333
* Calculates version bump for the packages based on the content
3434
* from the provided CHANGELOG file split into individual lines.
3535
*
36-
* @param lines Changelog content split into lines.
37-
* @param minimumVersionBump Minimum version bump for the package. Defaults to
38-
* `patch`.
39-
* @param currentVersion Current version of the package.
36+
* @param {string[]} lines Changelog content split into lines.
37+
* @param {('patch'|'minor'|'major')} [minimumVersionBump] Minimum version bump for the package.
38+
* Defaults to `patch`.
39+
* @param {string} [currentVersion] Current version of the package.
4040
*
41-
* @return Version bump when applicable, or null otherwise.
41+
* @return {string|null} Version bump when applicable, or null otherwise.
4242
*/
4343
function calculateVersionBumpFromChangelog(
44-
lines: string[],
45-
minimumVersionBump: 'patch' | 'minor' | 'major' = 'patch',
46-
currentVersion: string = '1.0.0'
44+
lines,
45+
minimumVersionBump = 'patch',
46+
currentVersion = '1.0.0'
4747
) {
4848
let changesDetected = false;
4949
let versionBump = null;

bin/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"esModuleInterop": true,
88
"target": "ES6",
99
"lib": [ "ES6", "ES2020.string" ],
10-
"types": [ "jest" ],
1110
"rootDir": ".",
1211

1312
// These scripts aren't published and packages don't depend on them.
@@ -23,6 +22,7 @@
2322
// Do not add to this list! The reason these are excluded is because
2423
// they have existing issues which need to be resolved. Fix them up!
2524
"plugin/commands/test/changelog.js",
25+
"plugin/commands/test/common.js",
2626
"api-docs/are-api-docs-unstaged.js",
2727
"api-docs/gen-block-lib-list.js",
2828
"api-docs/gen-components-docs/get-subcomponent-descriptions.mjs",
@@ -43,6 +43,7 @@
4343
"packages/build.mjs",
4444
"packages/check-build-type-declaration-files.js",
4545
"plugin/cli.js",
46+
"plugin/commands/common.js",
4647
"plugin/commands/packages.js",
4748
"plugin/lib/test/version.js",
4849
"validate-tsconfig.mjs"

0 commit comments

Comments
 (0)