Testing: Test across OS and Node.js version for commits to trunk (#72946)

* Testing: Test across OS and Node.js version for commits to trunk

* Temporarily re-include Windows for demonstration

* Normalize expected line endings for Prettier

* Normalize line endings at git checkout

Consistent with expectations for tooling, e.g. editorconfig

* Retain "All" label for default configuration

* Use cross-spawn for improved Windows compatibility in licenses script

* Revert "Temporarily re-include Windows for demonstration"

This reverts commit efc4207.

Co-authored-by: aduth <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: desrosj <[email protected]>
Co-authored-by: dream-encode <[email protected]>

Author: 4 people

.gitattributes

@@ -1,5 +1,5 @@
 # Set the default behavior, in case people don't have `core.autocrlf` set.
-* text=auto
+* text=auto eol=lf
 
 # Windows bat files in mobile/android.
 *.bat -text

.github/workflows/static-checks.yml

@@ -21,11 +21,26 @@ permissions: {}
 
 jobs:
     check:
-        name: All
-        runs-on: 'ubuntu-24.04'
+        name: All${{ (matrix.node != '20' || matrix.os != 'ubuntu-24.04') && format(' (Node.js {0} on {1})', matrix.node, contains(matrix.os, 'macos-') && 'MacOS' || contains(matrix.os, 'windows-') && 'Windows' || 'Linux') || '' }}
+        runs-on: ${{ matrix.os }}
         permissions:
             contents: read
         if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}
+        strategy:
+            matrix:
+                event: ['${{ github.event_name }}']
+                node: ['20', '22', '24']
+                os: ['macos-15', 'ubuntu-24.04', 'windows-2025']
+                exclude:
+                    # On PRs: Only test Node 20 on Ubuntu
+                    - event: 'pull_request'
+                      node: '22'
+                    - event: 'pull_request'
+                      node: '24'
+                    - event: 'pull_request'
+                      os: 'macos-15'
+                    - event: 'pull_request'
+                      os: 'windows-2025'
 
         steps:
             - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -36,9 +51,7 @@ jobs:
             - name: Use desired version of Node.js
               uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
               with:
-                  node-version-file: '.nvmrc'
-                  check-latest: true
-                  cache: npm
+                  node-version: ${{ matrix.node }}
 
             - name: Npm install
               # A "full" install is executed, since `npm ci` does not always exit

bin/check-licenses.mjs

@@ -3,7 +3,7 @@
 /**
  * External dependencies
  */
-import { spawnSync } from 'node:child_process';
+import spawn from 'cross-spawn';
 
 /**
  * Internal dependencies
@@ -25,7 +25,7 @@ const ignored = [ '@ampproject/remapping', 'webpack' ];
 
 /** @type {ReadonlyArray<PackageInfo>} */
 const workspacePackages = JSON.parse(
-	spawnSync(
+	spawn.sync(
 		'npm',
 		[
 			'query',
@@ -42,7 +42,7 @@ const workspacePackages = JSON.parse(
 const packageNames = workspacePackages.map( ( { name } ) => name );
 
 const dependenciesToProcess = JSON.parse(
-	spawnSync(
+	spawn.sync(
 		'npm',
 		[
 			'ls',

package-lock.json

@@ -105,6 +105,7 @@
 		"copy-webpack-plugin": "10.2.0",
 		"core-js-builder": "3.39.0",
 		"cross-env": "7.0.3",
+		"cross-spawn": "^7.0.6",
 		"css-loader": "6.2.0",
 		"deep-freeze": "0.0.1",
 		"equivalent-key-map": "0.2.2",