Refactor conditional statements

Co-authored-by: felixarntz <[email protected]>

Author: westonruter

plugins/speculation-rules/hooks.php

@@ -21,35 +21,42 @@
  */
 function plsr_is_speculative_loading_enabled(): bool {
 	$option = plsr_get_stored_setting_value();
-	return (
-		(
-			! is_user_logged_in()
-			||
-			'any' === $option['authentication']
-			||
-			( current_user_can( 'manage_options' ) && 'logged_out_and_admins' === $option['authentication'] )
-		)
+
+	// Disabled if the user is logged in, unless the setting explicitly allows the current user's role.
+	if (
+		( is_user_logged_in() )
+		&&
+		'any' !== $option['authentication']
 		&&
-		(
-			(bool) get_option( 'permalink_structure' )
-			||
-			/**
-			 * Filters whether speculative loading should be enabled even though the site does not use pretty permalinks.
-			 *
-			 * Since query parameters are commonly used by plugins for dynamic behavior that can change state, ideally any
-			 * such URLs are excluded from speculative loading. If the site does not use pretty permalinks though, they are
-			 * impossible to recognize. Therefore, speculative loading is disabled by default for those sites.
-			 *
-			 * For site owners of sites without pretty permalinks that are certain their site is not using such a pattern,
-			 * this filter can be used to still enable speculative loading at their own risk.
-			 *
-			 * @since 1.4.0
-			 *
-			 * @param bool $enabled Whether speculative loading is enabled even without pretty permalinks.
-			 */
-			(bool) apply_filters( 'plsr_enabled_without_pretty_permalinks', false )
-		)
-	);
+		( ! current_user_can( 'manage_options' ) || 'logged_out_and_admins' !== $option['authentication'] )
+	) {
+		return false;
+	}
+
+	// Disable if pretty permalinks are not enabled, unless explicitly overridden by the filter.
+	if (
+		! (bool) get_option( 'permalink_structure' )
+		&&
+		/**
+		 * Filters whether speculative loading should be enabled even though the site does not use pretty permalinks.
+		 *
+		 * Since query parameters are commonly used by plugins for dynamic behavior that can change state, ideally any
+		 * such URLs are excluded from speculative loading. If the site does not use pretty permalinks though, they are
+		 * impossible to recognize. Therefore, speculative loading is disabled by default for those sites.
+		 *
+		 * For site owners of sites without pretty permalinks that are certain their site is not using such a pattern,
+		 * this filter can be used to still enable speculative loading at their own risk.
+		 *
+		 * @since 1.4.0
+		 *
+		 * @param bool $enabled Whether speculative loading is enabled even without pretty permalinks.
+		 */
+		! apply_filters( 'plsr_enabled_without_pretty_permalinks', false )
+	) {
+		return false;
+	}
+
+	return true;
 }
 
 // Conditionally use either the WordPress Core API, or load the plugin's API implementation otherwise.