Account for route matching being case insensitive

Author: westonruter

plugins/image-prioritizer/helper.php

@@ -285,7 +285,12 @@ static function ( $host ) {
  * @noinspection PhpDocMissingThrowsInspection
  */
 function image_prioritizer_filter_rest_request_before_callbacks( $response, array $handler, WP_REST_Request $request ) {
-	if ( $request->get_method() !== 'POST' || OD_REST_API_NAMESPACE . OD_URL_METRICS_ROUTE !== trim( $request->get_route(), '/' ) ) {
+	if (
+		$request->get_method() !== 'POST'
+		||
+		// The strtolower()  is due to \WP_REST_Server::match_request_to_handler() using case-insensitive pattern match.
+		OD_REST_API_NAMESPACE . OD_URL_METRICS_ROUTE !== strtolower( trim( $request->get_route(), '/' ) )
+	) {
 		return $response;
 	}
 

plugins/image-prioritizer/tests/test-helper.php

@@ -760,7 +760,7 @@ public function data_provider_to_test_image_prioritizer_filter_rest_request_befo
 		};
 
 		return array(
-			'invalid_external_bg_image' => array(
+			'invalid_external_bg_image'               => array(
 				'set_up' => static function () use ( $get_sample_url_metric_data, $create_request ): WP_REST_Request {
 					$url_metric_data = $get_sample_url_metric_data();
 
@@ -786,7 +786,7 @@ public function data_provider_to_test_image_prioritizer_filter_rest_request_befo
 				},
 			),
 
-			'valid_external_bg_image'   => array(
+			'valid_external_bg_image'                 => array(
 				'set_up' => static function () use ( $get_sample_url_metric_data, $create_request ): WP_REST_Request {
 					$url_metric_data = $get_sample_url_metric_data();
 					$image_url = home_url( '/good.jpg' );
@@ -846,7 +846,26 @@ static function ( $pre, $parsed_args, $url ) use ( $image_url ) {
 				},
 			),
 
-			'not_store_post_request'    => array(
+			'invalid_external_bg_image_variant_route' => array(
+				'set_up' => static function () use ( $get_sample_url_metric_data, $create_request ): WP_REST_Request {
+					$url_metric_data = $get_sample_url_metric_data();
+
+					$url_metric_data['lcpElementExternalBackgroundImage'] = array(
+						'url'   => 'https://bad-origin.example.com/image.jpg',
+						'tag'   => 'DIV',
+						'id'    => null,
+						'class' => null,
+					);
+					$request = $create_request( $url_metric_data );
+					$request->set_route( str_replace( 'store', 'STORE', $request->get_route() ) );
+					return $request;
+				},
+				'assert' => function ( WP_REST_Request $request ): void {
+					$this->assertArrayNotHasKey( 'lcpElementExternalBackgroundImage', $request );
+				},
+			),
+
+			'not_store_post_request'                  => array(
 				'set_up' => static function () use ( $get_sample_url_metric_data, $create_request ): WP_REST_Request {
 					$url_metric_data = $get_sample_url_metric_data();
 					$url_metric_data['lcpElementExternalBackgroundImage'] = 'https://totally-different.example.com/';
@@ -860,7 +879,7 @@ static function ( $pre, $parsed_args, $url ) use ( $image_url ) {
 				},
 			),
 
-			'not_store_request'         => array(
+			'not_store_request'                       => array(
 				'set_up' => static function () use ( $get_sample_url_metric_data, $create_request ): WP_REST_Request {
 					$url_metric_data = $get_sample_url_metric_data();
 					$url_metric_data['lcpElementExternalBackgroundImage'] = 'https://totally-different.example.com/';