Add tests to ensure the REST API stores the new XPath format

Author: westonruter

plugins/optimization-detective/tests/storage/test-class-od-url-metrics-post-type.php

@@ -95,7 +95,16 @@ public function data_provider_test_get_url_metrics_from_post(): array {
 					'height' => 480,
 				),
 				'timestamp' => microtime( true ),
-				'elements'  => array(),
+				'elements'  => array(
+					array(
+						'xpath'              => '/HTML/BODY/DIV[@id=\'page\']/*[1][self::IMG]',
+						'isLCP'              => false,
+						'isLCPCandidate'     => true,
+						'intersectionRatio'  => 0.123,
+						'intersectionRect'   => $this->get_sample_dom_rect(),
+						'boundingClientRect' => $this->get_sample_dom_rect(),
+					),
+				),
 			),
 		);
 

plugins/optimization-detective/tests/storage/test-rest-api.php

@@ -115,6 +115,9 @@ function ( OD_URL_Metric_Store_Request_Context $context ) use ( &$stored_context
 		$this->assertCount( 1, $url_metrics, 'Expected number of URL Metrics stored.' );
 		$this->assertSame( $valid_params['elements'], $this->get_array_json_data( $url_metrics[0]->get( 'elements' ) ) );
 		$this->assertSame( $valid_params['viewport']['width'], $url_metrics[0]->get_viewport_width() );
+		$element = $url_metrics[0]->get( 'elements' )[0];
+		$this->assertStringStartsWith( '/HTML/BODY/DIV[@id=\'page\']/', $element->jsonSerialize()['xpath'] );
+		$this->assertStringStartsWith( '/HTML/BODY/DIV/', $element->get_xpath() ); // TODO: Remove once the XPath transitional period is over.
 
 		$expected_data = $valid_params;
 		unset( $expected_data['hmac'], $expected_data['slug'], $expected_data['current_etag'], $expected_data['cache_purge_post_id'] );
@@ -678,7 +681,7 @@ private function get_valid_params( array $extras = array() ): array {
 			array(
 				'viewport_width' => 480,
 				'element'        => array(
-					'xpath' => '/HTML/BODY/DIV/*[2][self::MAIN]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::IMG]',
+					'xpath' => '/HTML/BODY/DIV[@id=\'page\']/*[2][self::MAIN]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::IMG]',
 				),
 			)
 		)->jsonSerialize();