Fix tests

Author: westonruter

plugins/speculation-rules/tests/test-speculation-rules-settings.php

@@ -48,8 +48,9 @@ public function test_plsr_sanitize_setting( $input, array $expected ): void {
 	/** @return array<string, mixed> */
 	public function data_plsr_sanitize_setting(): array {
 		$default_value = array(
-			'mode'      => 'prerender',
-			'eagerness' => 'moderate',
+			'mode'           => 'prerender',
+			'eagerness'      => 'moderate',
+			'authentication' => 'logged_out',
 		);
 
 		return array(
@@ -67,46 +68,59 @@ public function data_plsr_sanitize_setting(): array {
 			),
 			'missing mode'        => array(
 				array( 'eagerness' => 'conservative' ),
-				array(
-					'mode'      => $default_value['mode'],
-					'eagerness' => 'conservative',
+				array_merge(
+					$default_value,
+					array(
+						'eagerness' => 'conservative',
+					)
 				),
 			),
 			'missing eagerness'   => array(
 				array( 'mode' => 'prefetch' ),
-				array(
-					'mode'      => 'prefetch',
-					'eagerness' => $default_value['eagerness'],
+				array_merge(
+					$default_value,
+					array(
+						'mode' => 'prefetch',
+					)
 				),
 			),
 			'invalid mode'        => array(
 				array(
 					'mode'      => 'something',
 					'eagerness' => 'eager',
 				),
-				array(
-					'mode'      => 'prerender',
-					'eagerness' => 'eager',
+				array_merge(
+					$default_value,
+					array(
+						'mode'      => 'prerender',
+						'eagerness' => 'eager',
+					)
 				),
 			),
 			'invalid eagerness'   => array(
 				array(
 					'mode'      => 'prefetch',
 					'eagerness' => 'something',
 				),
-				array(
-					'mode'      => 'prefetch',
-					'eagerness' => 'moderate',
+				array_merge(
+					$default_value,
+					array(
+						'mode'      => 'prefetch',
+						'eagerness' => 'moderate',
+					)
 				),
 			),
 			'valid fields'        => array(
 				array(
 					'mode'      => 'prefetch',
 					'eagerness' => 'conservative',
 				),
-				array(
-					'mode'      => 'prefetch',
-					'eagerness' => 'conservative',
+				array_merge(
+					$default_value,
+					array(
+						'mode'      => 'prefetch',
+						'eagerness' => 'conservative',
+					)
 				),
 			),
 		);
@@ -141,15 +155,17 @@ public function test_get_stored_setting_value(): void {
 		update_option(
 			'plsr_speculation_rules',
 			array(
-				'mode'      => 'prefetch',
-				'eagerness' => 'moderate',
+				'mode'           => 'prefetch',
+				'eagerness'      => 'moderate',
+				'authentication' => 'logged_out',
 			)
 		);
 		$settings = plsr_get_stored_setting_value();
 		$this->assertEquals(
 			array(
-				'mode'      => 'prefetch',
-				'eagerness' => 'moderate',
+				'mode'           => 'prefetch',
+				'eagerness'      => 'moderate',
+				'authentication' => 'logged_out',
 			),
 			$settings
 		);

plugins/speculation-rules/tests/test-speculation-rules-wp-core-api.php

@@ -9,8 +9,11 @@ class Test_Speculation_Rules_WP_Core_API extends WP_UnitTestCase {
 
 	/**
 	 * @covers ::plsr_filter_speculation_rules_configuration
+	 * @covers ::plsr_is_speculative_loading_enabled
 	 */
 	public function test_plsr_filter_speculation_rules_configuration_with_regular(): void {
+		add_filter( 'plsr_enabled_without_pretty_permalinks', '__return_true' );
+		$this->assertTrue( plsr_is_speculative_loading_enabled() );
 		$this->assertSame(
 			array(
 				'mode'      => 'prerender',
@@ -27,8 +30,11 @@ public function test_plsr_filter_speculation_rules_configuration_with_regular():
 
 	/**
 	 * @covers ::plsr_filter_speculation_rules_configuration
+	 * @covers ::plsr_is_speculative_loading_enabled
 	 */
 	public function test_plsr_filter_speculation_rules_configuration_with_invalid(): void {
+		add_filter( 'plsr_enabled_without_pretty_permalinks', '__return_true' );
+		$this->assertTrue( plsr_is_speculative_loading_enabled() );
 		$this->assertSame(
 			array(
 				'mode'      => 'prerender',