Remove development mode for all except od_can_optimize_response()

Author: westonruter

plugins/optimization-detective/readme.txt

@@ -104,12 +104,12 @@ add_filter( 'od_can_optimize_response', '__return_true' );
 
 **Filter:** `od_url_metrics_breakpoint_sample_size` (default: 3)
 
-Filters the sample size for a breakpoint's URL Metrics on a given URL. The sample size must be greater than zero. In plugin development mode, the default is 1. You can increase the sample size if you want better guarantees that the applied optimizations will be accurate:
+Filters the sample size for a breakpoint's URL Metrics on a given URL. The sample size must be greater than zero. You can increase the sample size if you want better guarantees that the applied optimizations will be accurate. During development, it may be helpful to reduce the sample size to 1:
 
 `
 <?php
 add_filter( 'od_url_metrics_breakpoint_sample_size', function (): int {
-	return 10;
+	return 1;
 } );
 `
 
@@ -126,7 +126,7 @@ add_filter( 'od_metrics_storage_lock_ttl', function ( int $ttl ): int {
 
 **Filter:** `od_url_metric_freshness_ttl` (default: 1 day in seconds)
 
-Filters the freshness age (TTL) for a given URL Metric. The freshness TTL must be at least zero, in which it considers URL Metrics to always be stale. In practice, the value should be at least an hour. In plugin development mode, this is set to zero by default. If your site content does not change frequently, you may want to increase the TTL to a week:
+Filters the freshness age (TTL) for a given URL Metric. The freshness TTL must be at least zero, in which it considers URL Metrics to always be stale. In practice, the value should be at least an hour. If your site content does not change frequently, you may want to increase the TTL to a week:
 
 `
 <?php
@@ -135,17 +135,33 @@ add_filter( 'od_url_metric_freshness_ttl', static function (): int {
 } );
 `
 
+During development, this can be useful to set to zero:
+
+`
+<?php
+add_filter( 'od_url_metric_freshness_ttl', static function (): int {
+    return 0;
+} );
+`
+
 **Filter:** `od_minimum_viewport_aspect_ratio` (default: 0.4)
 
 Filters the minimum allowed viewport aspect ratio for URL Metrics.
 
-The 0.4 value is intended to accommodate the phone with the greatest known aspect ratio at 21:9 when rotated 90 degrees to 9:21 (0.429). When in plugin development mode, the default value is 0; this is to account for Dev Tools likely being open.
+The 0.4 value is intended to accommodate the phone with the greatest known aspect ratio at 21:9 when rotated 90 degrees to 9:21 (0.429). During development you may want to set this to 0 to account Dev Tools likely being open and docked to the right:
+
+`
+<?php
+add_filter( 'od_minimum_viewport_aspect_ratio', static function (): int {
+    return 0;
+} );
+`
 
 **Filter:** `od_maximum_viewport_aspect_ratio` (default: 2.5)
 
 Filters the maximum allowed viewport aspect ratio for URL Metrics.
 
-The 2.5 value is intended to accommodate the phone with the greatest known aspect ratio at 21:9 (2.333). When in plugin development mode, the default value is PHP_INT_MAX; this is to account for Dev Tools likely being open.
+The 2.5 value is intended to accommodate the phone with the greatest known aspect ratio at 21:9 (2.333).
 
 During development when you have the DevTools console open on the bottom, for example, the viewport aspect ratio larger than normal. In this case, you may want to increase the maximum aspect ratio:
 

plugins/optimization-detective/storage/class-od-storage-lock.php

@@ -23,7 +23,6 @@ final class OD_Storage_Lock {
 	 * Gets the TTL (in seconds) for the URL Metric storage lock.
 	 *
 	 * @since 0.1.0
-	 * @since n.e.x.t The TTL is zero when in 'plugin' development mode.
 	 * @access private
 	 *
 	 * @return int TTL in seconds, greater than or equal to zero. A value of zero means that the storage lock should be disabled and thus that transients must not be used.
@@ -44,7 +43,7 @@ public static function get_ttl(): int {
 		 *
 		 * @param int $ttl TTL.
 		 */
-		$ttl = (int) apply_filters( 'od_url_metric_storage_lock_ttl', wp_is_development_mode( 'plugin' ) ? 0 : MINUTE_IN_SECONDS );
+		$ttl = (int) apply_filters( 'od_url_metric_storage_lock_ttl', MINUTE_IN_SECONDS );
 		return max( 0, $ttl );
 	}
 

plugins/optimization-detective/storage/data.php

@@ -16,7 +16,6 @@
  * When a URL Metric expires it is eligible to be replaced by a newer one if its viewport lies within the same breakpoint.
  *
  * @since 0.1.0
- * @since n.e.x.t The freshness TTL is set to zero when in 'plugin' development mode.
  * @access private
  *
  * @return int Expiration TTL in seconds.
@@ -32,7 +31,7 @@ function od_get_url_metric_freshness_ttl(): int {
 	 *
 	 * @param int $ttl Expiration TTL in seconds. Defaults to 1 day.
 	 */
-	$freshness_ttl = (int) apply_filters( 'od_url_metric_freshness_ttl', wp_is_development_mode( 'plugin' ) ? 0 : DAY_IN_SECONDS );
+	$freshness_ttl = (int) apply_filters( 'od_url_metric_freshness_ttl', DAY_IN_SECONDS );
 
 	if ( $freshness_ttl < 0 ) {
 		_doing_it_wrong(
@@ -186,7 +185,6 @@ function od_verify_url_metrics_storage_hmac( string $hmac, string $slug, string
  * Gets the minimum allowed viewport aspect ratio for URL Metrics.
  *
  * @since 0.6.0
- * @since n.e.x.t The default of 0 is used when in plugin development mode.
  * @access private
  *
  * @return float Minimum viewport aspect ratio for URL Metrics.
@@ -195,22 +193,20 @@ function od_get_minimum_viewport_aspect_ratio(): float {
 	/**
 	 * Filters the minimum allowed viewport aspect ratio for URL Metrics.
 	 *
-	 * The 0.4 default value is intended to accommodate the phone with the greatest known aspect ratio at 21:9 when
-	 * rotated 90 degrees to 9:21 (0.429). When in plugin development mode, the default value is 0; this is to account
-	 * for Dev Tools likely being open.
+	 * The 0.4 default value is intended to accommodate the phone with the greatest known aspect
+	 * ratio at 21:9 when rotated 90 degrees to 9:21 (0.429).
 	 *
 	 * @since 0.6.0
 	 *
 	 * @param float $minimum_viewport_aspect_ratio Minimum viewport aspect ratio.
 	 */
-	return (float) apply_filters( 'od_minimum_viewport_aspect_ratio', wp_is_development_mode( 'plugin' ) ? 0 : 0.4 );
+	return (float) apply_filters( 'od_minimum_viewport_aspect_ratio', 0.4 );
 }
 
 /**
  * Gets the maximum allowed viewport aspect ratio for URL Metrics.
  *
  * @since 0.6.0
- * @since n.e.x.t The default of PHP_INT_MAX is used when in plugin development mode.
  * @access private
  *
  * @return float Maximum viewport aspect ratio for URL Metrics.
@@ -219,14 +215,14 @@ function od_get_maximum_viewport_aspect_ratio(): float {
 	/**
 	 * Filters the maximum allowed viewport aspect ratio for URL Metrics.
 	 *
-	 * The 2.5 default value is intended to accommodate the phone with the greatest known aspect ratio at 21:9 (2.333).
-	 * When in plugin development mode, the default value is PHP_INT_MAX; this is to account for Dev Tools likely being open.
+	 * The 2.5 default value is intended to accommodate the phone with the greatest known aspect
+	 * ratio at 21:9 (2.333).
 	 *
 	 * @since 0.6.0
 	 *
 	 * @param float $maximum_viewport_aspect_ratio Maximum viewport aspect ratio.
 	 */
-	return (float) apply_filters( 'od_maximum_viewport_aspect_ratio', wp_is_development_mode( 'plugin' ) ? PHP_INT_MAX : 2.5 );
+	return (float) apply_filters( 'od_maximum_viewport_aspect_ratio', 2.5 );
 }
 
 /**
@@ -319,7 +315,6 @@ static function ( $original_breakpoint ) use ( $function_name ): int {
  * total of 6 URL Metrics stored for a given URL: 3 for mobile and 3 for desktop.
  *
  * @since 0.1.0
- * @since n.e.x.t The sample size is set to 1 when in 'plugin' development mode.
  * @access private
  *
  * @return int Sample size.
@@ -334,7 +329,7 @@ function od_get_url_metrics_breakpoint_sample_size(): int {
 	 *
 	 * @param int $sample_size Sample size. Defaults to 3.
 	 */
-	$sample_size = (int) apply_filters( 'od_url_metrics_breakpoint_sample_size', wp_is_development_mode( 'plugin' ) ? 1 : 3 );
+	$sample_size = (int) apply_filters( 'od_url_metrics_breakpoint_sample_size', 3 );
 
 	if ( $sample_size <= 0 ) {
 		_doing_it_wrong(