Chance typing for sprintf() placeholder

joemcgill · westonruter · web-flow · commit 7dd60d5532fc · 2024-12-13T10:01:28.000-06:00
Co-authored-by: Weston Ruter &lt;westonruter@google.com&gt;
diff --git a/plugins/auto-sizes/includes/improve-calculate-sizes.php b/plugins/auto-sizes/includes/improve-calculate-sizes.php
@@ -204,7 +204,7 @@ function auto_sizes_calculate_better_sizes( int $id, $size, string $align, int $
 			 * on the server. Otherwise, we need to rely on CSS functions.
 			 */
 			if ( str_ends_with( $layout_width, 'px' ) ) {
-				$layout_width = sprintf( '%1$spx', min( (int) $layout_width, $image_width ) );
+				$layout_width = sprintf( '%dpx', min( (int) $layout_width, $image_width ) );
 			} else {
 				$layout_width = sprintf( 'min(%1$s, %2$spx)', $layout_width, $image_width );
 			}

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ function auto_sizes_calculate_better_sizes( int $id, $size, string $align, int $`
`204`	`204`	`* on the server. Otherwise, we need to rely on CSS functions.`
`205`	`205`	`*/`
`206`	`206`	`if ( str_ends_with( $layout_width, 'px' ) ) {`
`207`		`- $layout_width = sprintf( '%1$spx', min( (int) $layout_width, $image_width ) );`
	`207`	`+ $layout_width = sprintf( '%dpx', min( (int) $layout_width, $image_width ) );`
`208`	`208`	`} else {`
`209`	`209`	`$layout_width = sprintf( 'min(%1$s, %2$spx)', $layout_width, $image_width );`
`210`	`210`	`}`