Convert invalid input to empty array

Co-authored-by: Weston Ruter <[email protected]>

Author: b1ink0

plugins/webp-uploads/hooks.php

@@ -813,11 +813,12 @@ function webp_uploads_enable_additional_mime_type_support_for_all_sizes( array $
  * @since n.e.x.t
  *
  * @param array<string, mixed>|mixed $file The uploaded file data.
- * @return array<string, mixed>|mixed The modified file data.
+ * @return array<string, mixed> The modified file data.
  */
-function webp_uploads_convert_palette_png_to_truecolor( $file ) {
+function webp_uploads_convert_palette_png_to_truecolor( $file ): array {
+	// Because plugins do bad things.
 	if ( ! is_array( $file ) ) {
-		return $file;
+		$file = array();
 	}
 	if ( ! isset( $file['tmp_name'], $file['name'] ) ) {
 		return $file;

plugins/webp-uploads/tests/test-load.php

@@ -1235,8 +1235,7 @@ public function data_to_test_webp_uploads_convert_palette_png_to_truecolor(): ar
 	 * @covers ::webp_uploads_convert_palette_png_to_truecolor
 	 */
 	public function test_webp_uploads_convert_palette_png_to_truecolor_conditions(): void {
-		$invalid_file = 'test';
-		$this->assertSame( $invalid_file, webp_uploads_convert_palette_png_to_truecolor( $invalid_file ) );
+		$this->assertSame( array(), webp_uploads_convert_palette_png_to_truecolor( 'test' ) );
 		$this->assertSameSets( array(), webp_uploads_convert_palette_png_to_truecolor( array() ) );
 
 		$file = array(