Skip to content

Commit 98fe0b0

Browse files
committed
Remove unused assert param in test_perflab_admin_pointer
1 parent 724e2df commit 98fe0b0

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

plugins/performance-lab/tests/includes/admin/test-load.php

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -126,28 +126,24 @@ public function data_provider_test_perflab_admin_pointer(): array {
126126
'set_up' => null,
127127
'hook_suffix' => null,
128128
'expected' => false,
129-
'assert' => null,
130129
'dismissed_wp_pointers' => '',
131130
),
132131
'edit.php' => array(
133132
'set_up' => null,
134133
'hook_suffix' => 'edit.php',
135134
'expected' => false,
136-
'assert' => null,
137135
'dismissed_wp_pointers' => '',
138136
),
139137
'dashboard_not_dismissed' => array(
140138
'set_up' => null,
141139
'hook_suffix' => 'index.php',
142140
'expected' => true,
143-
'assert' => null,
144141
'dismissed_wp_pointers' => 'perflab-feature-view-transitions',
145142
),
146143
'plugins_not_dismissed' => array(
147144
'set_up' => null,
148145
'hook_suffix' => 'plugins.php',
149146
'expected' => true,
150-
'assert' => null,
151147
'dismissed_wp_pointers' => 'perflab-feature-view-transitions',
152148
),
153149
'dashboard_new_dismissed' => array(
@@ -157,7 +153,6 @@ public function data_provider_test_perflab_admin_pointer(): array {
157153
},
158154
'hook_suffix' => 'index.php',
159155
'expected' => true,
160-
'assert' => null,
161156
'dismissed_wp_pointers' => 'perflab-admin-pointer,perflab-feature-view-transitions',
162157
),
163158
'dashboard_one_dismissed' => array(
@@ -167,7 +162,6 @@ public function data_provider_test_perflab_admin_pointer(): array {
167162
},
168163
'hook_suffix' => 'index.php',
169164
'expected' => false,
170-
'assert' => null,
171165
'dismissed_wp_pointers' => 'perflab-admin-pointer,perflab-feature-nocache-bfcache,perflab-feature-view-transitions',
172166
),
173167
'dashboard_all_dismissed' => array(
@@ -176,7 +170,6 @@ public function data_provider_test_perflab_admin_pointer(): array {
176170
},
177171
'hook_suffix' => 'index.php',
178172
'expected' => false,
179-
'assert' => null,
180173
'dismissed_wp_pointers' => implode( ',', array_keys( perflab_get_admin_pointers() ) ),
181174
),
182175
'perflab_screen_first_time' => array(
@@ -185,7 +178,6 @@ public function data_provider_test_perflab_admin_pointer(): array {
185178
},
186179
'hook_suffix' => 'options-general.php',
187180
'expected' => false,
188-
'assert' => null,
189181
'dismissed_wp_pointers' => implode( ',', array_keys( perflab_get_admin_pointers() ) ),
190182
),
191183
'perflab_screen_second_time' => array(
@@ -195,7 +187,6 @@ public function data_provider_test_perflab_admin_pointer(): array {
195187
},
196188
'hook_suffix' => 'options-general.php',
197189
'expected' => false,
198-
'assert' => null,
199190
'dismissed_wp_pointers' => implode( ',', array_keys( perflab_get_admin_pointers() ) ),
200191
),
201192
);
@@ -208,10 +199,9 @@ public function data_provider_test_perflab_admin_pointer(): array {
208199
* @param Closure|null $set_up Set up.
209200
* @param string|null $hook_suffix Hook suffix.
210201
* @param bool $expected Expected.
211-
* @param Closure|null $assert Assert.
212202
* @param string $dismissed_wp_pointers Dismissed admin pointers.
213203
*/
214-
public function test_perflab_admin_pointer( ?Closure $set_up, ?string $hook_suffix, bool $expected, ?Closure $assert, string $dismissed_wp_pointers ): void {
204+
public function test_perflab_admin_pointer( ?Closure $set_up, ?string $hook_suffix, bool $expected, string $dismissed_wp_pointers ): void {
215205
$user_id = self::factory()->user->create( array( 'role' => 'administrator' ) );
216206
wp_set_current_user( $user_id );
217207
if ( $set_up instanceof Closure ) {

0 commit comments

Comments
 (0)